Revert of depot_tools: only add mock infra_paths when test data is enabled

Revert of depot_tools: only add mock infra_paths when test data is enabled (patchset #1 id:1 of https://codereview.chromium.org/1917093004/ )

Reason for revert:
breaks skia bots

Original issue's description:
> depot_tools: only add mock infra_paths when test data is enabled
> 
> BUG=chromium:605919
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300193

TBR=sergiyb@chromium.org,maruel@chromium.org,machenbach@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919

[tandrii(chromium), 2016-04-26 18:51:49]

Created Revert of depot_tools: only add mock infra_paths when test data is
enabled

[commit-bot: I haz the power, 2016-04-26 18:51:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919093004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919093004/1

[commit-bot: I haz the power, 2016-04-26 18:52:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 18:52:01]

Failed to apply patch for recipe_modules/infra_paths/api.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: recipe_modules/infra_paths/api.py
  |diff --git a/recipe_modules/infra_paths/api.py
b/recipe_modules/infra_paths/api.py
  |index
7fd3e1ccd78d69a4d678e8703dfe17a89e65121b..1b902826f1138bce66defc1c86bc74f91d964835
100644
  |--- a/recipe_modules/infra_paths/api.py
  |+++ b/recipe_modules/infra_paths/api.py
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       recipe_modules/infra_paths/api.py
Index: recipe_modules/infra_paths/api.py
diff --git a/recipe_modules/infra_paths/api.py
b/recipe_modules/infra_paths/api.py
index
7fd3e1ccd78d69a4d678e8703dfe17a89e65121b..1b902826f1138bce66defc1c86bc74f91d964835
100644
--- a/recipe_modules/infra_paths/api.py
+++ b/recipe_modules/infra_paths/api.py
@@ -29,10 +29,9 @@
     else:
       self.set_config('buildbot')
 
-    if self._test_data.enabled:
-      for path in self._test_data.get('exists', []):
-        assert isinstance(path.base, NamedBasePath)
-        self.m.path.mock_add_paths(self[path.base.name].join(*path.pieces))
+    for path in self._test_data.get('exists', []):
+      assert isinstance(path.base, NamedBasePath)
+      self.m.path.mock_add_paths(self[path.base.name].join(*path.pieces))
 
   def __getitem__(self, name):
     self._lazy_set_config()

[tandrii(chromium), 2016-04-26 18:55:19]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-04-26 18:55:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919093004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919093004/1

[commit-bot: I haz the power, 2016-04-26 18:55:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 18:55:36]

Failed to apply patch for recipe_modules/infra_paths/api.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file recipe_modules/infra_paths/api.py
  Hunk #1 FAILED at 29.
  1 out of 1 hunk FAILED -- saving rejects to file
recipe_modules/infra_paths/api.py.rej

Patch:       recipe_modules/infra_paths/api.py
Index: recipe_modules/infra_paths/api.py
diff --git a/recipe_modules/infra_paths/api.py
b/recipe_modules/infra_paths/api.py
index
7fd3e1ccd78d69a4d678e8703dfe17a89e65121b..1b902826f1138bce66defc1c86bc74f91d964835
100644
--- a/recipe_modules/infra_paths/api.py
+++ b/recipe_modules/infra_paths/api.py
@@ -29,10 +29,9 @@
     else:
       self.set_config('buildbot')
 
-    if self._test_data.enabled:
-      for path in self._test_data.get('exists', []):
-        assert isinstance(path.base, NamedBasePath)
-        self.m.path.mock_add_paths(self[path.base.name].join(*path.pieces))
+    for path in self._test_data.get('exists', []):
+      assert isinstance(path.base, NamedBasePath)
+      self.m.path.mock_add_paths(self[path.base.name].join(*path.pieces))
 
   def __getitem__(self, name):
     self._lazy_set_config()

[tandrii(chromium), 2016-04-26 18:57:46]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-04-26 18:57:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919093004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919093004/1

[commit-bot: I haz the power, 2016-04-26 18:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 18:57:53]

Failed to apply patch for recipe_modules/infra_paths/api.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file recipe_modules/infra_paths/api.py
  Hunk #1 FAILED at 29.
  1 out of 1 hunk FAILED -- saving rejects to file
recipe_modules/infra_paths/api.py.rej

Patch:       recipe_modules/infra_paths/api.py
Index: recipe_modules/infra_paths/api.py
diff --git a/recipe_modules/infra_paths/api.py
b/recipe_modules/infra_paths/api.py
index
7fd3e1ccd78d69a4d678e8703dfe17a89e65121b..1b902826f1138bce66defc1c86bc74f91d964835
100644
--- a/recipe_modules/infra_paths/api.py
+++ b/recipe_modules/infra_paths/api.py
@@ -29,10 +29,9 @@
     else:
       self.set_config('buildbot')
 
-    if self._test_data.enabled:
-      for path in self._test_data.get('exists', []):
-        assert isinstance(path.base, NamedBasePath)
-        self.m.path.mock_add_paths(self[path.base.name].join(*path.pieces))
+    for path in self._test_data.get('exists', []):
+      assert isinstance(path.base, NamedBasePath)
+      self.m.path.mock_add_paths(self[path.base.name].join(*path.pieces))
 
   def __getitem__(self, name):
     self._lazy_set_config()

[Sergiy Byelozyorov, 2016-04-27 21:51:10]

closed