Image filters: de-nest SkImageFilter::Cache and Cache::Key.

Image filters: de-nest SkImageFilter::Cache and Cache::Key.

This reduces the public header, and also allows us to foward-
declare them, so we can remove an #include from all the 
SkDevice subclass headers.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919063002

Committed: https://skia.googlesource.com/skia/+/900c36779610dc65c42a5004ee3693fd70961ba4

[Stephen White, 2016-04-25 21:38:18]

Description was changed from

==========
Image filters: de-nest SkImageFilter::Cache and Cache::Key.

This allows us to foward-declare them, so we can remove an #include
from all the SkDevice subclass headers.

BUG=skia:
==========

to

==========
Image filters: de-nest SkImageFilter::Cache and Cache::Key.

This allows us to foward-declare them, so we can remove an #include
from all the SkDevice subclass headers.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-04-25 21:51:29]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 21:51:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919063002/60001

[Stephen White, 2016-04-25 21:51:48]

Description was changed from

==========
Image filters: de-nest SkImageFilter::Cache and Cache::Key.

This allows us to foward-declare them, so we can remove an #include
from all the SkDevice subclass headers.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Image filters: de-nest SkImageFilter::Cache and Cache::Key.

This allows us to foward-declare them, so we can remove an #include
from all the SkDevice subclass headers.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-04-25 21:51:48]

senorblanco@chromium.org changed reviewers:
+ reed@google.com

[Stephen White, 2016-04-25 21:52:19]

Description was changed from

==========
Image filters: de-nest SkImageFilter::Cache and Cache::Key.

This allows us to foward-declare them, so we can remove an #include
from all the SkDevice subclass headers.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Image filters: de-nest SkImageFilter::Cache and Cache::Key.

This reduces the public header, and also allows us to foward-
declare them, so we can remove an #include from all the 
SkDevice subclass headers.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-04-25 21:52:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 21:52:49]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[Stephen White, 2016-04-25 22:03:38]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 22:03:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919063002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919063002/80001

[commit-bot: I haz the power, 2016-04-25 22:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 22:06:18]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[Stephen White, 2016-04-25 22:07:59]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 22:08:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919063002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919063002/100001

[Stephen White, 2016-04-25 22:09:07]

reed@: PTAL. Thanks!

[commit-bot: I haz the power, 2016-04-25 22:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 22:12:39]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[robertphillips, 2016-04-26 11:52:21]

robertphillips@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-04-26 11:52:22]

lgtm

https://codereview.chromium.org/1919063002/diff/100001/src/core/SkImageFilter...
File src/core/SkImageFilter.cpp (right):

https://codereview.chromium.org/1919063002/diff/100001/src/core/SkImageFilter...
src/core/SkImageFilter.cpp:466: 
Could this now go in an SkImageFilterCache.cpp ?

[Stephen White, 2016-04-26 15:03:25]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 15:03:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919063002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919063002/100001

[commit-bot: I haz the power, 2016-04-26 15:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 15:10:30]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-04-26 20:02:01]

lgtm

[Stephen White, 2016-04-27 18:10:03]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 18:10:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919063002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919063002/140001

[Stephen White, 2016-04-27 18:12:31]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 18:12:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919063002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919063002/160001

[Stephen White, 2016-04-27 18:12:52]

https://codereview.chromium.org/1919063002/diff/100001/src/core/SkImageFilter...
File src/core/SkImageFilter.cpp (right):

https://codereview.chromium.org/1919063002/diff/100001/src/core/SkImageFilter...
src/core/SkImageFilter.cpp:466: 
On 2016/04/26 11:52:22, robertphillips wrote:
> Could this now go in an SkImageFilterCache.cpp ?

Done.

[commit-bot: I haz the power, 2016-04-27 18:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 18:29:07]

Dry run: This issue passed the CQ dry run.

[Stephen White, 2016-04-27 18:29:35]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2016-04-27 18:29:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/1919063002/#ps160001
(title: "Fix copyright")

[commit-bot: I haz the power, 2016-04-27 18:29:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919063002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919063002/160001

[commit-bot: I haz the power, 2016-04-27 18:31:25]

Description was changed from

==========
Image filters: de-nest SkImageFilter::Cache and Cache::Key.

This reduces the public header, and also allows us to foward-
declare them, so we can remove an #include from all the 
SkDevice subclass headers.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Image filters: de-nest SkImageFilter::Cache and Cache::Key.

This reduces the public header, and also allows us to foward-
declare them, so we can remove an #include from all the 
SkDevice subclass headers.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/900c36779610dc65c42a5004ee3693fd70961ba4
==========

[commit-bot: I haz the power, 2016-04-27 18:31:27]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/900c36779610dc65c42a5004ee3693fd70961ba4