Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Unified Diff: chrome/browser/android/ntp/popular_sites.h

Issue 1919043005: Remove Profile dependency from PopularSites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/popular_sites.h
diff --git a/chrome/browser/android/ntp/popular_sites.h b/chrome/browser/android/ntp/popular_sites.h
index 7cc520e93e23d89d4c8660a786c49df1c1a1a676..41523c5bd93ae331b78987f29bc9589b05022628 100644
--- a/chrome/browser/android/ntp/popular_sites.h
+++ b/chrome/browser/android/ntp/popular_sites.h
@@ -25,7 +25,8 @@ namespace user_prefs {
class PrefRegistrySyncable;
}
-class Profile;
+class PrefService;
+class TemplateURLService;
// Downloads and provides a list of suggested popular sites, for display on
// the NTP when there are not enough personalized suggestions. Caches the
@@ -56,7 +57,9 @@ class PopularSites {
// override the baked-in default version.
// Set |force_download| to enforce re-downloading the suggestions file, even
// if it already exists on disk.
- PopularSites(Profile* profile,
+ PopularSites(PrefService* prefs,
+ const TemplateURLService* template_url_service,
+ net::URLRequestContextGetter* download_context,
const std::string& override_country,
const std::string& override_version,
bool force_download,
@@ -64,7 +67,9 @@ class PopularSites {
// This fetches the popular sites from a given url and is only used for
// debugging through the popular-sites-internals page.
- PopularSites(Profile* profile,
+ PopularSites(PrefService* prefs,
+ const TemplateURLService* template_url_service,
+ net::URLRequestContextGetter* download_context,
const GURL& url,
const FinishedCallback& callback);
@@ -83,7 +88,9 @@ class PopularSites {
user_prefs::PrefRegistrySyncable* user_prefs);
private:
- PopularSites(Profile* profile,
+ PopularSites(PrefService* prefs,
+ const TemplateURLService* template_url_service,
+ net::URLRequestContextGetter* download_context,
const std::string& country,
const std::string& version,
const GURL& override_url,
@@ -113,7 +120,9 @@ class PopularSites {
base::FilePath local_path_;
- Profile* profile_;
+ PrefService* prefs_;
+ const TemplateURLService* template_url_service_;
+ net::URLRequestContextGetter* download_context_;
base::WeakPtrFactory<PopularSites> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698