Remove Profile dependency from PopularSites.

Remove Profile dependency from PopularSites.

Still depends on FileDownloader, but that's more difficult to work around, and it's lightweight enough that it could and probably should go into components itself.

BUG=603026
Committed: https://crrev.com/c6f7106fdd0ea5329422ccf7af6d4a90d691635b
Cr-Commit-Position: refs/heads/master@{#390357}

[sfiera, 2016-04-27 14:51:46]

Patchset #2 (id:20001) has been deleted

[sfiera, 2016-04-27 14:51:53]

Patchset #2 (id:40001) has been deleted

[sfiera, 2016-04-27 14:53:43]

Description was changed from

==========
Remove Profile dependency from PopularSites.

BUG=603026
==========

to

==========
Remove Profile dependency from PopularSites.

Still depends on FileDownloader, but that's more difficult to work around, and
it's lightweight enough that it could and probably should go into components
itself.

BUG=603026
==========

[sfiera, 2016-04-27 15:46:36]

sfiera@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2016-04-28 09:24:10]

LGTM

FWIW, it might not be a bad idea to stop using FileDownloader here completely.
We're using it to download a JSON file, and really we should run that through
the safe_json::JsonSanitizer before writing it to disk (or parsing it
in-process).

https://codereview.chromium.org/1919043005/diff/1/chrome/browser/android/ntp/...
File chrome/browser/android/ntp/popular_sites.cc (right):

https://codereview.chromium.org/1919043005/diff/1/chrome/browser/android/ntp/...
chrome/browser/android/ntp/popular_sites.cc:207: }
Can you move this to the previous line, so it's consistent with the constructor
above it?

[sfiera, 2016-04-28 12:07:46]

https://codereview.chromium.org/1919043005/diff/1/chrome/browser/android/ntp/...
File chrome/browser/android/ntp/popular_sites.cc (right):

https://codereview.chromium.org/1919043005/diff/1/chrome/browser/android/ntp/...
chrome/browser/android/ntp/popular_sites.cc:207: }
On 2016/04/28 09:24:10, Bernhard Bauer wrote:
> Can you move this to the previous line, so it's consistent with the
constructor
> above it?

Done.

[sfiera, 2016-04-28 12:07:50]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-04-28 12:07:51]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1919043005/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-28 12:08:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919043005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919043005/60001

[commit-bot: I haz the power, 2016-04-28 12:45:28]

Description was changed from

==========
Remove Profile dependency from PopularSites.

Still depends on FileDownloader, but that's more difficult to work around, and
it's lightweight enough that it could and probably should go into components
itself.

BUG=603026
==========

to

==========
Remove Profile dependency from PopularSites.

Still depends on FileDownloader, but that's more difficult to work around, and
it's lightweight enough that it could and probably should go into components
itself.

BUG=603026
==========

[commit-bot: I haz the power, 2016-04-28 12:45:28]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-04-30 17:17:46]

Patchset 2 (id:??) landed as
https://crrev.com/c6f7106fdd0ea5329422ccf7af6d4a90d691635b
Cr-Commit-Position: refs/heads/master@{#390357}

[commit-bot: I haz the power, 2016-04-30 17:55:20]

Description was changed from

==========
Remove Profile dependency from PopularSites.

Still depends on FileDownloader, but that's more difficult to work around, and
it's lightweight enough that it could and probably should go into components
itself.

BUG=603026
==========

to

==========
Remove Profile dependency from PopularSites.

Still depends on FileDownloader, but that's more difficult to work around, and
it's lightweight enough that it could and probably should go into components
itself.

BUG=603026

Committed: https://crrev.com/c6f7106fdd0ea5329422ccf7af6d4a90d691635b
Cr-Commit-Position: refs/heads/master@{#390357}
==========