Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1919043005: Remove Profile dependency from PopularSites. (Closed)

Created:
4 years, 7 months ago by sfiera
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Profile dependency from PopularSites. Still depends on FileDownloader, but that's more difficult to work around, and it's lightweight enough that it could and probably should go into components itself. BUG=603026 Committed: https://crrev.com/c6f7106fdd0ea5329422ccf7af6d4a90d691635b Cr-Commit-Position: refs/heads/master@{#390357}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -36 lines) Patch
M chrome/browser/android/ntp/most_visited_sites.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/android/ntp/popular_sites.h View 5 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/android/ntp/popular_sites.cc View 1 8 chunks +37 lines, -26 lines 0 comments Download
M chrome/browser/ui/webui/popular_sites_internals_message_handler.cc View 5 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
sfiera
4 years, 7 months ago (2016-04-27 15:46:36 UTC) #5
Bernhard Bauer
LGTM FWIW, it might not be a bad idea to stop using FileDownloader here completely. ...
4 years, 7 months ago (2016-04-28 09:24:10 UTC) #6
sfiera
https://codereview.chromium.org/1919043005/diff/1/chrome/browser/android/ntp/popular_sites.cc File chrome/browser/android/ntp/popular_sites.cc (right): https://codereview.chromium.org/1919043005/diff/1/chrome/browser/android/ntp/popular_sites.cc#newcode207 chrome/browser/android/ntp/popular_sites.cc:207: } On 2016/04/28 09:24:10, Bernhard Bauer wrote: > Can ...
4 years, 7 months ago (2016-04-28 12:07:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919043005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919043005/60001
4 years, 7 months ago (2016-04-28 12:08:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-04-28 12:45:28 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:46 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c6f7106fdd0ea5329422ccf7af6d4a90d691635b
Cr-Commit-Position: refs/heads/master@{#390357}

Powered by Google App Engine
This is Rietveld 408576698