Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Issue 1919013005: ARM64: disable ASM_LOCATION in release-sim builds (Closed)

Created:
4 years, 8 months ago by martyn.capewell
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM64: disable ASM_LOCATION in release-sim builds Disable ASM_LOCATION inline debug messages in release builds. This makes code size measurements more representative when using the simulator. BUG= Committed: https://crrev.com/21ce625b741e40a6c223973599208c4c9e973997 Cr-Commit-Position: refs/heads/master@{#35990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/arm64/macro-assembler-arm64.h View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
martyn.capewell
4 years, 8 months ago (2016-04-26 09:56:30 UTC) #2
martyn.capewell
Ping.
4 years, 7 months ago (2016-05-03 09:42:00 UTC) #3
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-03 10:55:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919013005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919013005/1
4 years, 7 months ago (2016-05-03 14:52:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 15:18:44 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 15:20:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21ce625b741e40a6c223973599208c4c9e973997
Cr-Commit-Position: refs/heads/master@{#35990}

Powered by Google App Engine
This is Rietveld 408576698