Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1918993003: Git patches created by webkitpy now always have filename prefixes (Closed)

Created:
4 years, 8 months ago by watk
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, tony
CC:
chromium-reviews, blink-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Git patches created by webkitpy now always have filename prefixes Previously, git patches created by Git.create_patch were subject to the diff.noprefix configuration setting that the user may have enabled. When it was enabled, DiffParser was using an incorrect regex to parse the filenames. Now, create_patch will always prefix paths with a/ and b/. BUG=606454 TEST=new unittest, manual Committed: https://crrev.com/31bcae4933857b32b30c4eaf66ce99031b814a0c Cr-Commit-Position: refs/heads/master@{#389601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
watk
Hi Tony, PTAL
4 years, 8 months ago (2016-04-25 21:07:42 UTC) #2
tony
This looks OK, but I haven't work on Chrome in years. I defer to Dirk ...
4 years, 8 months ago (2016-04-25 21:15:46 UTC) #3
watk
Oh oops, thanks for the response. +dpranke@
4 years, 8 months ago (2016-04-25 21:19:19 UTC) #5
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-25 21:23:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918993003/1
4 years, 8 months ago (2016-04-25 21:26:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 23:24:42 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 23:26:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31bcae4933857b32b30c4eaf66ce99031b814a0c
Cr-Commit-Position: refs/heads/master@{#389601}

Powered by Google App Engine
This is Rietveld 408576698