Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1918983003: Namespace capability classes. (Closed)

Created:
4 years, 8 months ago by Ben Goodger (Google)
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Namespace capability classes. Extracted from https://codereview.chromium.org/1910043002/ to help me isolate issues. TBR=sky@chromium.org BUG= Committed: https://crrev.com/66a819f0ddad18c01b69ab9c6a16e24444f82238 Cr-Commit-Position: refs/heads/master@{#389659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -36 lines) Patch
M components/mus/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +5 lines, -1 line 0 comments Download
M mash/catalog_viewer/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/views_examples/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M mash/init/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mash/login/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mash/quick_launch/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/catalog/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/manifest.json View 1 chunk +5 lines, -5 lines 0 comments Download
M services/shell/public/cpp/lib/interface_registry.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M services/shell/shell.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M services/shell/tests/connect/connect_test_app_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_singleton_app_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_unittests_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/lifecycle/lifecycle_unittest_manifest.json View 1 chunk +5 lines, -2 lines 0 comments Download
M services/shell/tests/shell/driver_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918983003/1
4 years, 8 months ago (2016-04-25 23:41:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 01:37:06 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 01:39:12 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/66a819f0ddad18c01b69ab9c6a16e24444f82238
Cr-Commit-Position: refs/heads/master@{#389659}

Powered by Google App Engine
This is Rietveld 408576698