Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1918953003: Landing Recent QUIC changes until 4/22/2016 14:55 UTC (Closed)

Created:
4 years, 8 months ago by rjshade
Modified:
4 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 4/22/2016 14:55 UTC Merged up to and including internal change 120547315. Deprecate --quic_use_cached_compressed_certs. Merge internal change: 120149656 Remove out of date comment about min cwnd enforcement and TCP MSS. Currently min_congestion_window is always set to 1 packet, but is potentially adjustable. Merge internal change: 120251020 Remove the 10 packet minimum for QUIC bandwidth resumption initial CWND. Flag protected by --quic_no_lower_bw_resumption_limit Merge internal change: 120255040 Generalize "bool needs_padding" to "int num_padding_bytes" to allow controlling of the amount of padding. No functional change intended. Merge internal change 120140207 Remove Rfc539 from the names of the QUIC ChaCha20Poly1305 classes. No functional change. Merge internal change: 120300747 Add a test target for quic_epoll_alarm_factory_test, and move the TestDelegate class over from the connection helper test. Merge internal change: 120334579 Deprecate gfe2_reloadable_flag_quic_ack_decimation2. Merge internal change: 120349803 Simplify QUIC's loss detection code by removing nack_count from TransmissionInfo. Protected by --quic_simplify_loss_detection. Merge internal change: 120403233 Remove ChaCha20Poly1305Rfc7539(De|En)crypter::IsSupported since Chrome is no longer using NSS on iOS. Merge internal change: 120406823 Add OnPaddingFrame() to QuicFramerVisitorInterface and QuicConnectionDebugVisitor. No functional change intended. Merge internal change: 120408040 Deprecate --gfe2_reloadable_flag_spdy_on_stream_end. Merge internal change: 120451808 Change HasUnackedPackets checking to a DCHECK in OnRetransmissionTimeout. Protected by -- FLAGS_gfe2_reloadable_flag_quic_always_has_unacked_packets_on_timeout, default true. Merge internal change: 120495394 Add two new Ack Decimation policies, AKD3 and AKD4, that wait a maximum of 1/8 min_rtt before sending an ack. Merge internal change: 120547315 Add a new QUIC connection option, IPFS, which causes the server to transition to perfect forward security as soon as possible, which makes the SHLO message head-of-line blocking in order to evaluate the performance impact. Merge internal change: 120245637 R=rch@chromium.org BUG= Committed: https://crrev.com/f88b3c7bc8e54908ba07bedd751cb6e38c645727 Cr-Commit-Position: refs/heads/master@{#389786}

Patch Set 1 #

Patch Set 2 : Deleted SpdyFramerTests missed while mergeing 120451808 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+728 lines, -1095 lines) Patch
M net/net.gypi View 3 chunks +7 lines, -6 lines 0 comments Download
M net/quic/congestion_control/general_loss_algorithm.cc View 4 chunks +30 lines, -15 lines 0 comments Download
M net/quic/congestion_control/general_loss_algorithm_test.cc View 11 chunks +44 lines, -18 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_bytes.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_bytes.cc View 4 chunks +17 lines, -7 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_bytes_test.cc View 5 chunks +56 lines, -8 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_packets.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_packets.cc View 3 chunks +15 lines, -5 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_packets_test.cc View 5 chunks +56 lines, -8 lines 0 comments Download
A + net/quic/crypto/chacha20_poly1305_decrypter.cc View 3 chunks +7 lines, -11 lines 0 comments Download
A + net/quic/crypto/chacha20_poly1305_decrypter_test.cc View 4 chunks +4 lines, -8 lines 0 comments Download
A + net/quic/crypto/chacha20_poly1305_encrypter.cc View 3 chunks +3 lines, -7 lines 0 comments Download
A + net/quic/crypto/chacha20_poly1305_encrypter_test.cc View 6 chunks +12 lines, -32 lines 0 comments Download
D net/quic/crypto/chacha20_poly1305_rfc7539_decrypter.h View 1 chunk +0 lines, -47 lines 0 comments Download
D net/quic/crypto/chacha20_poly1305_rfc7539_decrypter.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D net/quic/crypto/chacha20_poly1305_rfc7539_decrypter_test.cc View 1 chunk +0 lines, -185 lines 0 comments Download
D net/quic/crypto/chacha20_poly1305_rfc7539_encrypter.h View 1 chunk +0 lines, -42 lines 0 comments Download
D net/quic/crypto/chacha20_poly1305_rfc7539_encrypter.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D net/quic/crypto/chacha20_poly1305_rfc7539_encrypter_test.cc View 1 chunk +0 lines, -181 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 4 chunks +9 lines, -14 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 6 chunks +8 lines, -26 lines 0 comments Download
M net/quic/crypto/quic_decrypter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/quic_encrypter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection.h View 3 chunks +6 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 6 chunks +30 lines, -5 lines 0 comments Download
M net/quic/quic_connection_test.cc View 3 chunks +190 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +4 lines, -3 lines 0 comments Download
M net/quic/quic_flags.cc View 2 chunks +14 lines, -11 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_framer.cc View 2 chunks +17 lines, -3 lines 0 comments Download
M net/quic/quic_framer_test.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 4 chunks +6 lines, -19 lines 0 comments Download
M net/quic/quic_packet_creator.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_packet_creator.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 9 chunks +48 lines, -8 lines 0 comments Download
M net/quic/quic_protocol.h View 7 chunks +19 lines, -8 lines 0 comments Download
M net/quic/quic_protocol.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/spdy/spdy_framer.cc View 3 chunks +3 lines, -13 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 8 chunks +0 lines, -275 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_epoll_alarm_factory_test.cc View 1 chunk +15 lines, -2 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rjshade
4 years, 8 months ago (2016-04-26 14:11:27 UTC) #1
Ryan Hamilton
lgtm
4 years, 8 months ago (2016-04-26 14:22:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918953003/1
4 years, 8 months ago (2016-04-26 14:22:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918953003/20001
4 years, 8 months ago (2016-04-26 14:31:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 15:25:50 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 15:27:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f88b3c7bc8e54908ba07bedd751cb6e38c645727
Cr-Commit-Position: refs/heads/master@{#389786}

Powered by Google App Engine
This is Rietveld 408576698