Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1918943002: Remove SkEncodedInfo kPreSwizzled_Color from public API (Closed)

Created:
4 years, 7 months ago by msarett
Modified:
4 years, 7 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -293 lines) Patch
M include/codec/SkEncodedInfo.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M src/codec/SkSwizzler.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/codec/SkSwizzler.cpp View 1 chunk +294 lines, -286 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
msarett
I *think* this is better. Let me know what you think. https://codereview.chromium.org/1918943002/diff/1/src/codec/SkSwizzler.cpp File src/codec/SkSwizzler.cpp (right): ...
4 years, 7 months ago (2016-04-25 16:58:45 UTC) #3
scroggo
lgtm
4 years, 7 months ago (2016-04-25 18:19:57 UTC) #4
reed1
I think its a preferable API. Is it acceptable from the impl side?
4 years, 7 months ago (2016-04-25 18:20:40 UTC) #5
reed1
api lgtm
4 years, 7 months ago (2016-04-25 18:20:49 UTC) #6
msarett
On 2016/04/25 18:20:40, reed1 wrote: > I think its a preferable API. Is it acceptable ...
4 years, 7 months ago (2016-04-25 18:26:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918943002/1
4 years, 7 months ago (2016-04-25 18:26:38 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-25 18:41:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/68758aed88b16d67658f634e8dcd855404fedb8a

Powered by Google App Engine
This is Rietveld 408576698