Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1918903004: Make support for async/await syntax optional in the frontend. (Closed)

Created:
4 years, 8 months ago by sigurdm
Modified:
4 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, ahe
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make support for async/await syntax optional in the frontend. patch from issue 1899293005 at patchset 20001 (http://crrev.com/1899293005#ps20001) Modified to fix issue with synthetic Scripts BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/d56b1c6928b967f4d4aeb9b805cd12b79ec94764

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -94 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 1 chunk +25 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 3 chunks +32 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +42 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 2 chunks +30 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sigurdm
4 years, 8 months ago (2016-04-26 14:46:12 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/1918903004/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1918903004/diff/1/pkg/compiler/lib/src/compiler.dart#newcode445 pkg/compiler/lib/src/compiler.dart:445: if (!library.compilationUnit.script.isSynthesized) { -> 'if (!library.isSynthesized) {'
4 years, 8 months ago (2016-04-27 07:34:58 UTC) #3
sigurdm
https://codereview.chromium.org/1918903004/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1918903004/diff/1/pkg/compiler/lib/src/compiler.dart#newcode445 pkg/compiler/lib/src/compiler.dart:445: if (!library.compilationUnit.script.isSynthesized) { On 2016/04/27 07:34:57, Johnni Winther wrote: ...
4 years, 8 months ago (2016-04-27 07:48:17 UTC) #5
sigurdm
Committed patchset #2 (id:40001) manually as d56b1c6928b967f4d4aeb9b805cd12b79ec94764 (presubmit successful).
4 years, 8 months ago (2016-04-27 07:58:19 UTC) #7
ahe
4 years, 7 months ago (2016-04-28 07:13:40 UTC) #8
Message was sent while issue was closed.
Thank you, now we have no more patches to dart2js. Yay!

Powered by Google App Engine
This is Rietveld 408576698