Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1918903003: Revert of bot_update: call gclient sync after checking out a gerrit ref (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of bot_update: call gclient sync after checking out a gerrit ref (patchset #1 id:1 of https://codereview.chromium.org/1904663002/ ) Reason for revert: I believe this is mostly likely to have broken Angle, but this is speculative. http://crbug.com/606150 Original issue's description: > bot_update: call gclient sync after checking out a gerrit ref > > BUG=chromium:602906 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300109 TBR=hinoka@chromium.org,yyanagisawa@chromium.org,hinoka@google.com,phajdan.jr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:602906 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M recipe_modules/bot_update/resources/bot_update.py View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
tandrii(chromium)
Created Revert of bot_update: call gclient sync after checking out a gerrit ref
4 years, 8 months ago (2016-04-25 19:18:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918903003/1
4 years, 8 months ago (2016-04-25 19:18:43 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 19:21:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300159

Powered by Google App Engine
This is Rietveld 408576698