Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1918903002: Rename net/ _openssl files (Closed)

Created:
4 years, 8 months ago by svaldez
Modified:
4 years, 8 months ago
Reviewers:
Eran Messeri, davidben
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename net/ _openssl files R=davidben@chromium.org BUG=604728 Committed: https://crrev.com/b8539ccb7fbc802f753d2782642c6af522dc9caa Cr-Commit-Position: refs/heads/master@{#389590}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix unused method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -809 lines) Patch
M net/cert/ct_log_verifier.cc View 3 chunks +95 lines, -0 lines 0 comments Download
D net/cert/ct_log_verifier_openssl.cc View 1 chunk +0 lines, -113 lines 0 comments Download
A + net/cert/ct_objects_extractor.cc View 11 chunks +28 lines, -32 lines 0 comments Download
D net/cert/ct_objects_extractor_openssl.cc View 1 chunk +0 lines, -364 lines 0 comments Download
A + net/cert/jwk_serializer.cc View 2 chunks +4 lines, -5 lines 0 comments Download
D net/cert/jwk_serializer_openssl.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M net/net.gypi View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/token_binding.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
A + net/ssl/token_binding.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
D net/ssl/token_binding_openssl.cc View 1 chunk +0 lines, -166 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
svaldez
4 years, 8 months ago (2016-04-25 15:17:58 UTC) #1
Eran Messeri
lgtm for net/cert/ct_* stuff.
4 years, 8 months ago (2016-04-25 16:39:28 UTC) #3
davidben
lgtm https://codereview.chromium.org/1918903002/diff/1/net/ssl/token_binding.cc File net/ssl/token_binding.cc (right): https://codereview.chromium.org/1918903002/diff/1/net/ssl/token_binding.cc#newcode36 net/ssl/token_binding.cc:36: bool IsTokenBindingSupported() { Either now or in a ...
4 years, 8 months ago (2016-04-25 16:53:24 UTC) #4
svaldez
https://codereview.chromium.org/1918903002/diff/1/net/ssl/token_binding.cc File net/ssl/token_binding.cc (right): https://codereview.chromium.org/1918903002/diff/1/net/ssl/token_binding.cc#newcode36 net/ssl/token_binding.cc:36: bool IsTokenBindingSupported() { On 2016/04/25 16:53:24, davidben wrote: > ...
4 years, 8 months ago (2016-04-25 19:44:05 UTC) #5
svaldez
https://codereview.chromium.org/1918903002/diff/1/net/ssl/token_binding.cc File net/ssl/token_binding.cc (right): https://codereview.chromium.org/1918903002/diff/1/net/ssl/token_binding.cc#newcode36 net/ssl/token_binding.cc:36: bool IsTokenBindingSupported() { On 2016/04/25 16:53:24, davidben wrote: > ...
4 years, 8 months ago (2016-04-25 19:44:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918903002/20001
4 years, 8 months ago (2016-04-25 19:44:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 22:33:32 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 22:35:49 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b8539ccb7fbc802f753d2782642c6af522dc9caa
Cr-Commit-Position: refs/heads/master@{#389590}

Powered by Google App Engine
This is Rietveld 408576698