Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1918893002: Initial version of SingleContextManager. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+677 lines, -0 lines) Patch
A pkg/analysis_server/lib/src/single_context_manager.dart View 1 chunk +366 lines, -0 lines 2 comments Download
A pkg/analysis_server/test/single_context_manager_test.dart View 1 chunk +309 lines, -0 lines 1 comment Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 8 months ago (2016-04-25 15:17:09 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/1918893002/diff/1/pkg/analysis_server/lib/src/single_context_manager.dart File pkg/analysis_server/lib/src/single_context_manager.dart (right): https://codereview.chromium.org/1918893002/diff/1/pkg/analysis_server/lib/src/single_context_manager.dart#newcode5 pkg/analysis_server/lib/src/single_context_manager.dart:5: library analysis_server.src.experimental; "experimental" --> "single_context_manager" https://codereview.chromium.org/1918893002/diff/1/pkg/analysis_server/lib/src/single_context_manager.dart#newcode155 pkg/analysis_server/lib/src/single_context_manager.dart:155: // ...
4 years, 8 months ago (2016-04-25 15:31:06 UTC) #2
scheglov
4 years, 8 months ago (2016-04-25 15:38:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
337862bca2fb7e0f29a97cb77c58f3250342d2f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698