Remove SkEncodedInfo kUnknown_Color and kUnknown_Alpha from public API

Remove SkEncodedInfo kUnknown_Color and kUnknown_Alpha from public API

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918873002

Committed: https://skia.googlesource.com/skia/+/ac6c75056f1e8e5a5d7c3c4b64df4113368d9c31

[msarett, 2016-04-25 14:54:42]

Description was changed from

==========
Remove SkEncodedInfo kUnknown_Color and kUnknown_Alpha from public API

BUG=skia:
==========

to

==========
Remove SkEncodedInfo kUnknown_Color and kUnknown_Alpha from public API

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-25 14:59:10]

msarett@google.com changed reviewers:
+ reed@google.com, scroggo@google.com

[msarett, 2016-04-25 14:59:11]

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkWebpCodec.h
File src/codec/SkWebpCodec.h (right):

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkWebpCodec.h#new...
src/codec/SkWebpCodec.h:37: static bool ReadHeader(SkStream* stream, SkCodec**
outCodec);
Leon, do you remember why SkWebpCodec doesn't need to override onRewind()?

[reed1, 2016-04-25 15:06:37]

api lgtm

[scroggo, 2016-04-25 15:10:44]

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkPngCodec.cpp
File src/codec/SkPngCodec.cpp (right):

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkPngCodec.cpp#ne...
src/codec/SkPngCodec.cpp:264: static int bytes_per_pixel(int bitsPerPixel) {
Before I scan this 200 line block line by line to see if anything changed, did
anything change? Or is this just a move?

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkWebpCodec.cpp
File src/codec/SkWebpCodec.cpp (right):

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkWebpCodec.cpp#n...
src/codec/SkWebpCodec.cpp:110: if (SkWebpCodec::ReadHeader(stream, &outCodec)) {
Since ReadHeader is used only in this method, I don't see any reason to separate
the two. I would delete this method entirely, and repurpose webp_parse_header
into NewFromStream.

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkWebpCodec.h
File src/codec/SkWebpCodec.h (right):

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkWebpCodec.h#new...
src/codec/SkWebpCodec.h:37: static bool ReadHeader(SkStream* stream, SkCodec**
outCodec);
On 2016/04/25 14:59:10, msarett wrote:
> Leon, do you remember why SkWebpCodec doesn't need to override onRewind()?

It doesn't store any information locally. e.g. SkPngCodec has a png_struct etc,
which it needs to delete and recreate. But SkWebCodec has nothing like that.

[msarett, 2016-04-25 15:18:21]

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkPngCodec.cpp
File src/codec/SkPngCodec.cpp (right):

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkPngCodec.cpp#ne...
src/codec/SkPngCodec.cpp:264: static int bytes_per_pixel(int bitsPerPixel) {
On 2016/04/25 15:10:43, scroggo wrote:
> Before I scan this 200 line block line by line to see if anything changed, did
> anything change? Or is this just a move?

Sorry I should I have mentioned - yes this is all a move.

I made changes to read_header() and NewFromStream.

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkWebpCodec.cpp
File src/codec/SkWebpCodec.cpp (right):

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkWebpCodec.cpp#n...
src/codec/SkWebpCodec.cpp:110: if (SkWebpCodec::ReadHeader(stream, &outCodec)) {
On 2016/04/25 15:10:43, scroggo wrote:
> Since ReadHeader is used only in this method, I don't see any reason to
separate
> the two. I would delete this method entirely, and repurpose webp_parse_header
> into NewFromStream.

Of course, that's much better :).

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkWebpCodec.h
File src/codec/SkWebpCodec.h (right):

https://codereview.chromium.org/1918873002/diff/1/src/codec/SkWebpCodec.h#new...
src/codec/SkWebpCodec.h:37: static bool ReadHeader(SkStream* stream, SkCodec**
outCodec);
On 2016/04/25 15:10:43, scroggo wrote:
> On 2016/04/25 14:59:10, msarett wrote:
> > Leon, do you remember why SkWebpCodec doesn't need to override onRewind()?
> 
> It doesn't store any information locally. e.g. SkPngCodec has a png_struct
etc,
> which it needs to delete and recreate. But SkWebCodec has nothing like that.

Acknowledged.

[scroggo, 2016-04-25 15:27:42]

lgtm

[msarett, 2016-04-25 15:30:35]

The CQ bit was checked by msarett@google.com

[msarett, 2016-04-25 15:30:35]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1918873002/#ps20001
(title: "Response to comments")

[commit-bot: I haz the power, 2016-04-25 15:30:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918873002/20001

[commit-bot: I haz the power, 2016-04-25 15:32:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 15:32:42]

Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[msarett, 2016-04-25 16:07:05]

The CQ bit was checked by msarett@google.com

[msarett, 2016-04-25 16:07:05]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1918873002/#ps40001
(title: "Fix errors")

[commit-bot: I haz the power, 2016-04-25 16:07:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918873002/40001

[commit-bot: I haz the power, 2016-04-25 16:30:26]

Description was changed from

==========
Remove SkEncodedInfo kUnknown_Color and kUnknown_Alpha from public API

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove SkEncodedInfo kUnknown_Color and kUnknown_Alpha from public API

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ac6c75056f1e8e5a5d7c3c4b64df4113368d9c31
==========

[commit-bot: I haz the power, 2016-04-25 16:30:27]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ac6c75056f1e8e5a5d7c3c4b64df4113368d9c31