Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1918863002: Removing use_openssl from cronet build (Closed)

Created:
4 years, 8 months ago by svaldez
Modified:
4 years, 8 months ago
Reviewers:
mef, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing use_openssl from cronet build With the removal of use_openssl, cronet no longer needs to explicitly set use_openssl. BUG=604728 Committed: https://crrev.com/938019f8964f7bf41312f8b1f8e2fd7f88194168 Cr-Commit-Position: refs/heads/master@{#389489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M components/cronet/tools/cr_cronet.py View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/tools/package_ios.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
svaldez
4 years, 8 months ago (2016-04-25 15:01:39 UTC) #2
xunjieli
lgtm
4 years, 8 months ago (2016-04-25 15:07:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918863002/1
4 years, 8 months ago (2016-04-25 15:17:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/127090)
4 years, 8 months ago (2016-04-25 15:23:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918863002/1
4 years, 8 months ago (2016-04-25 16:04:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 16:11:04 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 16:12:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/938019f8964f7bf41312f8b1f8e2fd7f88194168
Cr-Commit-Position: refs/heads/master@{#389489}

Powered by Google App Engine
This is Rietveld 408576698