Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1918833003: Documentation: FAQ: drop shadow (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
jcgregorio, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2016-04-25 (Monday) 12:35:25 EDT #

Patch Set 3 : 2016-04-25 (Monday) 12:36:50 EDT #

Total comments: 2

Patch Set 4 : 2016-04-25 (Monday) 13:08:33 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M site/user/tips.md View 1 2 3 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
hal.canary
ptal
4 years, 7 months ago (2016-04-25 16:38:00 UTC) #5
jcgregorio
https://codereview.chromium.org/1918833003/diff/40001/site/user/tips.md File site/user/tips.md (right): https://codereview.chromium.org/1918833003/diff/40001/site/user/tips.md#newcode186 site/user/tips.md:186: const SkScalar textSize = 24.0f; The resulting image is ...
4 years, 7 months ago (2016-04-25 16:46:23 UTC) #7
hal.canary
https://codereview.chromium.org/1918833003/diff/40001/site/user/tips.md File site/user/tips.md (right): https://codereview.chromium.org/1918833003/diff/40001/site/user/tips.md#newcode186 site/user/tips.md:186: const SkScalar textSize = 24.0f; On 2016/04/25 16:46:23, jcgregorio ...
4 years, 7 months ago (2016-04-25 17:08:58 UTC) #9
jcgregorio
lgtm
4 years, 7 months ago (2016-04-25 20:54:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918833003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918833003/60001
4 years, 7 months ago (2016-04-25 21:26:45 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 11:49:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/ff6596460e322521fadd86bad3f205d47d8ab054

Powered by Google App Engine
This is Rietveld 408576698