[MD Settings] Add initial autofill sub page.

[MD Settings] Add initial autofill sub page.

BUG=607347, 607348
Committed: https://crrev.com/0988153e2d3f409403033de45c06a243304b55f5
Cr-Commit-Position: refs/heads/master@{#390258}

[hcarmona, 2016-04-27 22:22:31]

hcarmona@chromium.org changed reviewers:
+ dpapad@chromium.org

[hcarmona, 2016-04-27 22:22:32]

PTAL

[dpapad, 2016-04-27 22:38:50]

https://codereview.chromium.org/1918823011/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
(right):

https://codereview.chromium.org/1918823011/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html:7:
<link rel="import"
href="chrome://md-settings/passwords_and_forms_page/autofill_section.html">
Doesn't
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
also need to be updated for those files to become available through a chrome://
URL?

[Dan Beam, 2016-04-27 22:45:16]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-04-27 22:45:16]

i assume "autofill" means "addresses"? or does this mean both addresses and
credit cards?

either way, please update the tracker and assign yourself one or both of the
remaining passwords and forms work items

[Dan Beam, 2016-04-27 22:45:22]

Description was changed from

==========
Add initial autofill sub page.

BUG=546836
==========

to

==========
Add initial autofill sub page.

BUG=546836
==========

[Dan Beam, 2016-04-27 22:45:22]

dbeam@chromium.org changed reviewers:
- dbeam@chromium.org

[hcarmona, 2016-04-27 23:03:11]

Description was changed from

==========
Add initial autofill sub page.

BUG=546836
==========

to

==========
Add initial autofill sub page.

BUG=607347,607348
==========

[hcarmona, 2016-04-27 23:07:14]

I've updated the tracker and created 2 issues to track the changes. Autofill
means both addresses and credit cards, so I added both issues. Other CLs will be
one or the other.

Also updated the compiled_resources2.gyp

https://codereview.chromium.org/1918823011/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
(right):

https://codereview.chromium.org/1918823011/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html:7:
<link rel="import"
href="chrome://md-settings/passwords_and_forms_page/autofill_section.html">
On 2016/04/27 22:38:50, dpapad wrote:
> Doesn't
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> also need to be updated for those files to become available through a
chrome://
> URL?

You're right. Not sure why I didn't get errors about this...
Fixed.

[dpapad, 2016-04-27 23:33:30]

LGTM

https://codereview.chromium.org/1918823011/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
(right):

https://codereview.chromium.org/1918823011/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html:4:
<dom-module id="autofill-section">
FYI, I was going to suggest renaming this to settings-autofill-section, but
since I was not sure if this is indeed a convention we have been following or
just me, I started a thread about it

started a thread about naming
https://groups.google.com/a/chromium.org/d/msg/chromium-settings/O2JEvJHVyb0/....

https://codereview.chromium.org/1918823011/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html:6:
<style include="settings-shared"></style>
Nit (optional): Can you add something as follows here
<!--- TODO(hcarmona): Implement this -->

So that it is obvious that this code will be more useful soon.

[dpapad, 2016-04-27 23:40:00]

Also (optional) I have found adding a prefix like "MD Settings:" or "[MD
Settings]" in all CL descrptions related to MD settings pretty useful when going
through git history to look for something.

[hcarmona, 2016-04-27 23:50:46]

Description was changed from

==========
Add initial autofill sub page.

BUG=607347,607348
==========

to

==========
[MD Settings] Add initial autofill sub page.

BUG=607347,607348
==========

[hcarmona, 2016-04-27 23:57:27]

https://codereview.chromium.org/1918823011/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
(right):

https://codereview.chromium.org/1918823011/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html:4:
<dom-module id="autofill-section">
On 2016/04/27 23:33:29, dpapad wrote:
> FYI, I was going to suggest renaming this to settings-autofill-section, but
> since I was not sure if this is indeed a convention we have been following or
> just me, I started a thread about it
> 
> started a thread about naming
>
https://groups.google.com/a/chromium.org/d/msg/chromium-settings/O2JEvJHVyb0/....

Changed for consistency.

https://codereview.chromium.org/1918823011/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html:6:
<style include="settings-shared"></style>
On 2016/04/27 23:33:29, dpapad wrote:
> Nit (optional): Can you add something as follows here
> <!--- TODO(hcarmona): Implement this -->
> 
> So that it is obvious that this code will be more useful soon.

Done.

[hcarmona, 2016-04-28 00:13:13]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-04-28 00:13:13]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1918823011/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2016-04-28 00:13:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918823011/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918823011/40001

[commit-bot: I haz the power, 2016-04-28 00:41:39]

Description was changed from

==========
[MD Settings] Add initial autofill sub page.

BUG=607347,607348
==========

to

==========
[MD Settings] Add initial autofill sub page.

BUG=607347,607348
==========

[commit-bot: I haz the power, 2016-04-28 00:41:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:15:06]

Patchset 3 (id:??) landed as
https://crrev.com/0988153e2d3f409403033de45c06a243304b55f5
Cr-Commit-Position: refs/heads/master@{#390258}

[commit-bot: I haz the power, 2016-04-30 17:53:25]

Description was changed from

==========
[MD Settings] Add initial autofill sub page.

BUG=607347,607348
==========

to

==========
[MD Settings] Add initial autofill sub page.

BUG=607347,607348

Committed: https://crrev.com/0988153e2d3f409403033de45c06a243304b55f5
Cr-Commit-Position: refs/heads/master@{#390258}
==========