Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 1918823010: Mark serviceworker-echo-referrer-from-default-document.html as crashing (Closed)

Created:
4 years, 7 months ago by Justin Donnelly
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark serviceworker-echo-referrer-from-default-document.html as crashing on Win7 and Linux. Add test expectation that http/tests/fetch/referrer/serviceworker-echo-referrer-from-default-document.html will crash on WebKit Win7 (dbg) and WebKit Linux (dbg). BUG=607156 TBR=yhirano Committed: https://crrev.com/5fd5cd7875ed4aa759e6c9beaad633bffda38714 Cr-Commit-Position: refs/heads/master@{#390192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Justin Donnelly
Maybe this should be one line with just the following: [ Linux Mac10.11 Win Debug ...
4 years, 7 months ago (2016-04-27 20:14:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918823010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918823010/1
4 years, 7 months ago (2016-04-27 20:15:40 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-04-27 20:15:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918823010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918823010/1
4 years, 7 months ago (2016-04-27 20:17:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 21:25:28 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:13:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fd5cd7875ed4aa759e6c9beaad633bffda38714
Cr-Commit-Position: refs/heads/master@{#390192}

Powered by Google App Engine
This is Rietveld 408576698