🐾 Enable instrumentation tests on Android Swarm Builder

testing/buildbot/chromium.android.json

Index: testing/buildbot/chromium.android.json
diff --git a/testing/buildbot/chromium.android.json b/testing/buildbot/chromium.android.json
index f0da75c1b0cb5493f9ce838e528dda1e228bb8b5..a8aa841bf35db045b6b24c0188f4b0124ae6f448 100644
--- a/testing/buildbot/chromium.android.json
+++ b/testing/buildbot/chromium.android.json
@@ -21,6 +21,18 @@
             }
           ]
         },
+        "test": "android_webview_test_apk"
+      },
+      {
+        "swarming": {
+          "can_use_on_swarming_builders": true,
+          "dimension_sets": [
+            {
+              "device_os": "KTU84P",
+              "device_type": "hammerhead"
+            }
+          ]
+        },
         "test": "android_webview_unittests"
       },
       {
@@ -36,6 +48,10 @@
         "test": "base_unittests"
       },
       {
+        "apk_under_test": "Blimp.apk",

[ghost stip (do not use), 2016/04/27 02:30:34]

this is ignored IIUC

+        "override_compile_targets": [

[ghost stip (do not use), 2016/04/27 02:30:34]

don't think you actually need this

+          "blimp_test_apk"
+        ],
         "swarming": {
           "can_use_on_swarming_builders": true,
           "dimension_sets": [
@@ -45,7 +61,8 @@
             }
           ]
         },
-        "test": "blimp_unittests"
+        "test": "blimp_test_apk",
+        "test_apk": "BlimpTest.apk"

[ghost stip (do not use), 2016/04/27 02:30:34]

ignored IIUC

       },
       {
         "swarming": {
@@ -57,7 +74,7 @@
             }
           ]
         },
-        "test": "breakpad_unittests"
+        "test": "blimp_unittests"
       },
       {
         "swarming": {
@@ -69,7 +86,7 @@
             }
           ]
         },
-        "test": "cc_unittests"
+        "test": "breakpad_unittests"
       },
       {
         "swarming": {
@@ -81,7 +98,7 @@
             }
           ]
         },
-        "test": "components_browsertests"
+        "test": "cc_unittests"
       },
       {
         "swarming": {
@@ -93,7 +110,7 @@
             }
           ]
         },
-        "test": "components_unittests"
+        "test": "chrome_public_test_apk"

[ghost stip (do not use), 2016/04/27 02:30:34]

surprised _apk works, publicly it's chrome_public_test. guessing it's because of
https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/gn_iso...
though

[jbudorick, 2016/04/27 03:03:05]

it doesn't:
https://build.chromium.org/p/chromium.android/builders/Android%20Swarm%20Buil...

"chrome_public_test_apk_apk_run"

[jbudorick, 2016/04/27 03:25:07]

and this actually brings up another interesting blocker (that may or may not
have come up already in other channels, I don't remember): the _apk_run targets
that would be generated here had we left off the terminal _apk don't exist in
gn.

       },
       {
         "swarming": {
@@ -105,7 +122,7 @@
             }
           ]
         },
-        "test": "content_browsertests"
+        "test": "chrome_sync_shell_test_apk"
       },
       {
         "swarming": {
@@ -117,7 +134,7 @@
             }
           ]
         },
-        "test": "content_unittests"
+        "test": "components_browsertests"
       },
       {
         "swarming": {
@@ -129,7 +146,7 @@
             }
           ]
         },
-        "test": "device_unittests"
+        "test": "components_unittests"
       },
       {
         "swarming": {
@@ -141,7 +158,7 @@
             }
           ]
         },
-        "test": "events_unittests"
+        "test": "content_browsertests"
       },
       {
         "swarming": {
@@ -153,7 +170,7 @@
             }
           ]
         },
-        "test": "gl_tests"
+        "test": "content_shell_test_apk"
       },
       {
         "swarming": {
@@ -165,7 +182,7 @@
             }
           ]
         },
-        "test": "gpu_unittests"
+        "test": "content_unittests"
       },
       {
         "swarming": {
@@ -177,7 +194,7 @@
             }
           ]
         },
-        "test": "ipc_tests"
+        "test": "device_unittests"
       },
       {
         "swarming": {
@@ -189,7 +206,7 @@
             }
           ]
         },
-        "test": "media_unittests"
+        "test": "events_unittests"
       },
       {
         "swarming": {
@@ -201,7 +218,7 @@
             }
           ]
         },
-        "test": "net_unittests"
+        "test": "gl_tests"
       },
       {
         "swarming": {
@@ -213,7 +230,7 @@
             }
           ]
         },
-        "test": "sandbox_linux_unittests"
+        "test": "gpu_unittests"
       },
       {
         "swarming": {
@@ -225,7 +242,7 @@
             }
           ]
         },
-        "test": "sql_unittests"
+        "test": "ipc_tests"
       },
       {
         "swarming": {
@@ -237,7 +254,7 @@
             }
           ]
         },
-        "test": "sync_unit_tests"
+        "test": "media_unittests"
       },
       {
         "swarming": {
@@ -249,7 +266,7 @@
             }
           ]
         },
-        "test": "ui_android_unittests"
+        "test": "net_unittests"
       },
       {
         "swarming": {
@@ -261,7 +278,7 @@
             }
           ]
         },
-        "test": "ui_base_unittests"
+        "test": "sandbox_linux_unittests"
       },
       {
         "swarming": {
@@ -273,7 +290,7 @@
             }
           ]
         },
-        "test": "ui_touch_selection_unittests"
+        "test": "sql_unittests"
       },
       {
         "swarming": {
@@ -285,15 +302,9 @@
             }
           ]
         },
-        "test": "unit_tests"
-      }
-    ],
-    "instrumentation_tests": [
+        "test": "sync_unit_tests"
+      },
       {
-        "apk_under_test": "Blimp.apk",
-        "override_compile_targets": [
-          "blimp_test_apk"
-        ],
         "swarming": {
           "can_use_on_swarming_builders": true,
           "dimension_sets": [
@@ -303,8 +314,7 @@
             }
           ]
         },
-        "test": "blimp_test_apk",
-        "test_apk": "BlimpTest.apk"
+        "test": "ui_android_unittests"
       },
       {
         "swarming": {
@@ -316,7 +326,7 @@
             }
           ]
         },
-        "test": "chrome_public_test_apk"
+        "test": "ui_base_unittests"
       },
       {
         "swarming": {
@@ -328,7 +338,7 @@
             }
           ]
         },
-        "test": "chrome_sync_shell_test_apk"
+        "test": "ui_touch_selection_unittests"
       },
       {
         "swarming": {
@@ -340,7 +350,7 @@
             }
           ]
         },
-        "test": "content_shell_test_apk"
+        "test": "unit_tests"
       }
     ]
   },