Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1918823006:
🐾 Enable instrumentation tests on Android Swarm Builder (Closed)
DescriptionEnable instrumentation tests on Android Swarm Builder
BUG=589318
Committed: https://crrev.com/42aecd2a6a2b51ac56fa594000007ba2eb784da1
Cr-Commit-Position: refs/heads/master@{#389974}
Patch Set 1 #
Total comments: 2
Patch Set 2 : add android_webview_test_apk #
Total comments: 6
Messages
Total messages: 23 (7 generated)
agrieve@chromium.org changed reviewers: + jbudorick@chromium.org
agrieve@chromium.org changed reviewers: + dpranke@chromium.org
https://codereview.chromium.org/1918823006/diff/1/testing/buildbot/chromium.a... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/1918823006/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.json:37: }, This was previously missing android_webview_test_apk; it should be here, too.
https://codereview.chromium.org/1918823006/diff/1/testing/buildbot/chromium.a... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/1918823006/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.json:37: }, On 2016/04/27 00:58:43, jbudorick wrote: > This was previously missing android_webview_test_apk; it should be here, too. good catch. added.
chromium.android.json lgtm
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918823006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918823006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
lgtm, I guess. I didn't realize we were getting rid of the instrumentation steps ...
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918823006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918823006/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Enable instrumentation tests on Android Swarm Builder BUG=589318 ========== to ========== Enable instrumentation tests on Android Swarm Builder BUG=589318 Committed: https://crrev.com/42aecd2a6a2b51ac56fa594000007ba2eb784da1 Cr-Commit-Position: refs/heads/master@{#389974} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/42aecd2a6a2b51ac56fa594000007ba2eb784da1 Cr-Commit-Position: refs/heads/master@{#389974}
Message was sent while issue was closed.
stip@chromium.org changed reviewers: + stip@chromium.org
Message was sent while issue was closed.
may require some cleanup, there's some things in that dict that aren't really used https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/chromi... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/chromi... testing/buildbot/chromium.android.json:51: "apk_under_test": "Blimp.apk", this is ignored IIUC https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/chromi... testing/buildbot/chromium.android.json:52: "override_compile_targets": [ don't think you actually need this https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/chromi... testing/buildbot/chromium.android.json:65: "test_apk": "BlimpTest.apk" ignored IIUC https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/chromi... testing/buildbot/chromium.android.json:113: "test": "chrome_public_test_apk" surprised _apk works, publicly it's chrome_public_test. guessing it's because of https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/gn_iso... though
Message was sent while issue was closed.
yeah, stip's right. I messed up the instrumentation -> gtest stuff in my review. https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/chromi... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/chromi... testing/buildbot/chromium.android.json:113: "test": "chrome_public_test_apk" On 2016/04/27 02:30:34, stip wrote: > surprised _apk works, publicly it's chrome_public_test. guessing it's because of > https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/gn_iso... > though it doesn't: https://build.chromium.org/p/chromium.android/builders/Android%20Swarm%20Buil... "chrome_public_test_apk_apk_run"
Message was sent while issue was closed.
https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/chromi... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/chromi... testing/buildbot/chromium.android.json:113: "test": "chrome_public_test_apk" On 2016/04/27 03:03:05, jbudorick wrote: > On 2016/04/27 02:30:34, stip wrote: > > surprised _apk works, publicly it's chrome_public_test. guessing it's because > of > > > https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/gn_iso... > > though > > it doesn't: > https://build.chromium.org/p/chromium.android/builders/Android%20Swarm%20Buil... > > "chrome_public_test_apk_apk_run" and this actually brings up another interesting blocker (that may or may not have come up already in other channels, I don't remember): the _apk_run targets that would be generated here had we left off the terminal _apk don't exist in gn.
Message was sent while issue was closed.
On 2016/04/27 03:25:07, jbudorick wrote: > https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/chromi... > File testing/buildbot/chromium.android.json (right): > > https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/chromi... > testing/buildbot/chromium.android.json:113: "test": "chrome_public_test_apk" > On 2016/04/27 03:03:05, jbudorick wrote: > > On 2016/04/27 02:30:34, stip wrote: > > > surprised _apk works, publicly it's chrome_public_test. guessing it's > because > > of > > > > > > https://codereview.chromium.org/1918823006/diff/20001/testing/buildbot/gn_iso... > > > though > > > > it doesn't: > > > https://build.chromium.org/p/chromium.android/builders/Android%20Swarm%20Buil... > > > > "chrome_public_test_apk_apk_run" > > and this actually brings up another interesting blocker (that may or may not > have come up already in other channels, I don't remember): the _apk_run targets > that would be generated here had we left off the terminal _apk don't exist in > gn. Just going to revert this and try again tomorrow.
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1916303007/ by agrieve@chromium.org. The reason for reverting is: ninja: error: unknown target 'android_webview_test_apk_apk_run'. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
