Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1918813002: Fix kSubset_Mode tests on non-native swizzles (Closed)

Created:
4 years, 8 months ago by msarett
Modified:
4 years, 8 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M dm/DMSrcSink.cpp View 2 chunks +7 lines, -6 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
msarett
This should fix the untriaged images on Gold. https://codereview.chromium.org/1918813002/diff/1/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (right): https://codereview.chromium.org/1918813002/diff/1/dm/DMSrcSink.cpp#newcode586 dm/DMSrcSink.cpp:586: // ...
4 years, 8 months ago (2016-04-25 13:25:50 UTC) #3
scroggo
lgtm
4 years, 8 months ago (2016-04-25 13:43:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918813002/1
4 years, 8 months ago (2016-04-25 13:45:38 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 14:05:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c7eb4905c4629eba44e76d98ce5e32546f739974

Powered by Google App Engine
This is Rietveld 408576698