Issue 19188002: Fix --deopt-every-n-times flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19188002: Fix --deopt-every-n-times flag (Closed)

Created:
7 years, 5 months ago by Jakob Kummerow

Modified:
7 years, 5 months ago

Reviewers:
titzer, Michael Starzinger

CC:
v8-dev, titzer

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix --deopt-every-n-times flag (was broken since r15640) R=titzer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15669

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

titzer

lgtm https://codereview.chromium.org/19188002/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/19188002/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode952 src/ia32/lithium-codegen-ia32.cc:952: ASSERT(frame_is_built_); Ah ha, missed this case. What about ...

7 years, 5 months ago (2013-07-15 13:08:22 UTC) #2

Jakob Kummerow

On 2013/07/15 13:08:22, titzer wrote: > What about x64? lithium-codegen-x64.cc:656: ASSERT(FLAG_deopt_every_n_times == 0); // Not ...

7 years, 5 months ago (2013-07-15 13:35:52 UTC) #3

Jakob Kummerow

Committed patchset #1 manually as r15669 (presubmit successful).

7 years, 5 months ago (2013-07-15 13:36:43 UTC) #4

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages