Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1918753002: Improve default value handling for SVGSVGElement.width/height (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Improve default value handling for SVGSVGElement.width/height When a length attribute is either removed or set to an invalid value, it would get set to '0'. It should however be set to the initial value specified for the attribute (possibly presentation attribute) in question. The test svg/custom/disallow-non-lengths-in-attrs.html is tweaked to accommodate for this. BUG=604093 Review URL: https://codereview.chromium.org/1901673003 Cr-Commit-Position: refs/heads/master@{#388250} (cherry picked from commit 6cd726f3f3ed5d5fecfe725bb3c85dc2cac39e85) Committed: https://chromium.googlesource.com/chromium/src/+/20a1e339aeac762f323b93575c6cbad86f88cfbb

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
fs
4 years, 8 months ago (2016-04-25 08:31:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
20a1e339aeac762f323b93575c6cbad86f88cfbb.

Powered by Google App Engine
This is Rietveld 408576698