Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1918743002: Align image sizes for SVG with raster image size (Closed)

Created:
4 years, 8 months ago by davve
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Align image sizes for SVG with raster image size The background geometry calculations has heuristics for tiling image sizes optimized for integer image sizes (at least in effective zoom == 1). Rounding SVG image sizes before zoom application makes SVG images fit better into the existing heuristics. BUG=601011 Review URL: https://codereview.chromium.org/1912063004 Cr-Commit-Position: refs/heads/master@{#389158} (cherry picked from commit c53a0d93dd13a025e65668dda879f78142459e04) Committed: https://chromium.googlesource.com/chromium/src/+/dfb0382772681567f2ef5f55948912a223997c8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/background-non-integer-viewbox.html View 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/background-non-integer-viewbox-expected.html View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleImage.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
davve
4 years, 8 months ago (2016-04-25 08:22:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dfb0382772681567f2ef5f55948912a223997c8e.

Powered by Google App Engine
This is Rietveld 408576698