Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1918733002: Make android_webview_test fit isolate naming convention. (Closed)

Created:
4 years, 8 months ago by ghost stip (do not use)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mikecase+watch_chromium.org, android-webview-reviews_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make android_webview_test fit isolate naming convention. This allows use of the gtest test generator and easy swarming. https://codereview.chromium.org/1915003004/ is the build-side change. https://chromereviews.googleplex.com/411237013/ is the build_internal-side change. BUG=525873 Committed: https://crrev.com/5274ed693aa0703078df02dc62b520c991bbd648 Cr-Commit-Position: refs/heads/master@{#389886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -40 lines) Patch
M android_webview/android_webview_test_apk.isolate View 1 chunk +23 lines, -9 lines 0 comments Download
D android_webview/android_webview_test_apk_run.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
A + android_webview/android_webview_test_data.isolate View 0 chunks +-1 lines, --1 lines 0 comments Download
M android_webview/android_webview_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/android/buildbot/bb_device_steps.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
ghost stip (do not use)
ptal! jbudorick: review sgurun: android_webview OWNERS
4 years, 8 months ago (2016-04-25 22:18:33 UTC) #5
jbudorick
lgtm
4 years, 8 months ago (2016-04-26 00:51:54 UTC) #9
sgurun-gerrit only
On 2016/04/26 00:51:54, jbudorick wrote: > lgtm lgtm
4 years, 8 months ago (2016-04-26 16:49:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918733002/1
4 years, 8 months ago (2016-04-26 19:20:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 21:15:04 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 21:16:50 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5274ed693aa0703078df02dc62b520c991bbd648
Cr-Commit-Position: refs/heads/master@{#389886}

Powered by Google App Engine
This is Rietveld 408576698