Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 1918723002: Mac fullscreen low power: Plumb through to AcceleratedWidgetMac (Closed)

Created:
4 years, 8 months ago by ccameron
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, spqchan
Base URL:
https://chromium.googlesource.com/chromium/src.git@plumb
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac fullscreen low power: Plumb through to AcceleratedWidgetMac Add a CAContext in the GPU process for the fullscreen low power AVSampleBufferDisplayLayer recently added. Plumb this CAContext's id through to AcceleratedWidgetMac's GotCAContextFrame function. Follow-on patches will enable showing a separate NSWindow with this AVSampleBufferDisplayLayer as its contents. TBR=sievers BUG=594460 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3ae0dfa02e589d5a0ca56685d0cb2a28ae3818b3 Cr-Commit-Position: refs/heads/master@{#390781}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix test build #

Patch Set 4 : Fix widget test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -20 lines) Patch
M content/browser/compositor/software_output_device_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M content/common/accelerated_surface_buffers_swapped_params_mac.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu_host_messages.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel_manager_delegate.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel_test_common.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel_test_common.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.mm View 1 2 4 chunks +16 lines, -4 lines 0 comments Download
M ui/accelerated_widget_mac/accelerated_widget_mac.h View 1 3 chunks +8 lines, -1 line 0 comments Download
M ui/accelerated_widget_mac/accelerated_widget_mac.mm View 1 5 chunks +27 lines, -8 lines 0 comments Download
M ui/views/widget/native_widget_mac_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
ccameron
4 years, 8 months ago (2016-04-25 05:56:04 UTC) #3
ccameron
Okay, this should be ready to go now
4 years, 7 months ago (2016-04-27 23:48:39 UTC) #5
erikchen
lgtm looks like test failure are real.
4 years, 7 months ago (2016-04-28 01:06:39 UTC) #6
ccameron
Thanks -- fixed the test build. wfh@: IPC review please sievers@: please stamp gpu/ and ...
4 years, 7 months ago (2016-04-28 20:43:05 UTC) #9
Will Harris
lgtm for content/common/gpu_host_messages.h
4 years, 7 months ago (2016-04-28 20:48:02 UTC) #10
ccameron
Adding tapted to stamp views/ change
4 years, 7 months ago (2016-04-29 07:02:18 UTC) #12
tapted
lgtm
4 years, 7 months ago (2016-04-29 07:44:05 UTC) #13
ccameron
sievers@, ping for stamp
4 years, 7 months ago (2016-04-29 16:32:12 UTC) #14
ccameron
TBRing sievers
4 years, 7 months ago (2016-04-29 20:56:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918723002/60001
4 years, 7 months ago (2016-04-29 20:57:19 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-29 22:11:33 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:29:34 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3ae0dfa02e589d5a0ca56685d0cb2a28ae3818b3
Cr-Commit-Position: refs/heads/master@{#390781}

Powered by Google App Engine
This is Rietveld 408576698