Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1918713006: SkDocument::CreateXPS fix roll (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M include/core/SkDocument.h View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918713006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918713006/1
4 years, 7 months ago (2016-04-27 19:07:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/eabaf798249e7fc5d2d636ce8c19f8423b11319e
4 years, 7 months ago (2016-04-27 19:07:58 UTC) #7
reed1
Can we add these back when we want to test them (and still not break ...
4 years, 7 months ago (2016-05-19 16:56:11 UTC) #9
hal.canary
4 years, 7 months ago (2016-05-20 20:43:38 UTC) #10
Message was sent while issue was closed. 
On 2016/05/19 16:56:11, reed1 wrote:
> Can we add these back when we want to test them (and still not break the
roll)?

We don't need the CreateXPS functions since we have MakeXPS.  No clients call
CreateXPS.

Chrome does not build either SkDocument_XPS.cpp or SkDocument_XPS_None.cpp.

Powered by Google App Engine
This is Rietveld 408576698