Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1918693003: Fix EOS reached before decoder fallback (Closed)

Created:
4 years, 8 months ago by tguilbert
Modified:
4 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix EOS reached before decoder fallback If the demuxer stream we are pulling buffers from only has a few frames (1 to 3 for example), we can reach the demuxer's end of stream before knowing that we need to fall back to a software decoder. DecoderStream is left with the |decoding_eos_| flag set, and runs into a DCHECK when calling ReadFromDemuxerStream() upon decoder reinitialization. This change updates CanDecodeMore() to take into account |fallback_buffers_|, so we can attempt to decode fallback buffers before returning EOS frames. BUG=606084 REVIEW=DaleCurtis TEST=updated unit tests Committed: https://crrev.com/8f4a3f7d9d522797568b75ab201ed9aa9506afb6 Cr-Commit-Position: refs/heads/master@{#389687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M media/base/fake_demuxer_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/fake_demuxer_stream.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/filters/decoder_stream.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tguilbert
PTAL. Thanks!
4 years, 8 months ago (2016-04-25 19:48:11 UTC) #2
DaleCurtis
lgtm
4 years, 8 months ago (2016-04-25 22:57:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918693003/1
4 years, 8 months ago (2016-04-25 23:07:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 03:54:01 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 03:55:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f4a3f7d9d522797568b75ab201ed9aa9506afb6
Cr-Commit-Position: refs/heads/master@{#389687}

Powered by Google App Engine
This is Rietveld 408576698