Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: chrome/browser/extensions/extension_messages_apitest.cc

Issue 191863002: Disable the externally connectable tests on windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_messages_apitest.cc
diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc
index 593a73f1ed4dd940b65e35b34d1d3bc9d1f4ac36..36e2f383686c708540371d87b51ea6392b38b70a 100644
--- a/chrome/browser/extensions/extension_messages_apitest.cc
+++ b/chrome/browser/extensions/extension_messages_apitest.cc
@@ -134,6 +134,10 @@ IN_PROC_BROWSER_TEST_F(PanelMessagingTest, MessagingPanel) {
ASSERT_TRUE(RunExtensionTest("messaging/connect_panel")) << message_;
}
+// XXX(kalman): All web messaging tests disabled on windows due to extreme
+// flakiness. See http://crbug.com/350517.
+#if !defined(OS_WIN)
+
// Tests externally_connectable between a web page and an extension.
//
// TODO(kalman): Test between extensions. This is already tested in this file,
@@ -953,6 +957,8 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,
CanConnectAndSendMessages("invalid"));
}
+#endif // !defined(OS_WIN) - http://crbug.com/350517.
+
} // namespace
}; // namespace extensions
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698