Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

Issue 1918613002: DevTools: Switching to custom user agent no longer clears preexisting value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-added readonly Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
index 9b80ad4c61d8c3441fecf6bde28b345ceb4fd6db..4fdfd2637ee52498bb940cf985c755e2f5939e04 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
@@ -129,7 +129,6 @@ WebInspector.NetworkConfigView.createUserAgentSelectAndInput = function()
otherUserAgentElement.readOnly = true;
} else {
otherUserAgentElement.readOnly = false;
- otherUserAgentElement.value = "";
otherUserAgentElement.focus();
}
}
@@ -166,7 +165,7 @@ WebInspector.NetworkConfigView.createUserAgentSelectAndInput = function()
function textDoubleClicked()
{
if (userAgentSelectElement.selectedIndex === 0)
- return;
lushnikov 2016/04/26 16:39:17 semicolon is actually needed after the "return"
luoe 2016/04/26 23:11:42 Done.
+ return
userAgentSelectElement.selectedIndex = 0;
userAgentSelected();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698