Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

Issue 1918613002: DevTools: Switching to custom user agent no longer clears preexisting value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made input always editable Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 */ 8 */
9 WebInspector.NetworkConfigView = function() 9 WebInspector.NetworkConfigView = function()
10 { 10 {
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 userAgentSelectElement.selectedIndex = 0; 108 userAgentSelectElement.selectedIndex = 0;
109 109
110 var otherUserAgentElement = createElement("input"); 110 var otherUserAgentElement = createElement("input");
111 otherUserAgentElement.type = "text"; 111 otherUserAgentElement.type = "text";
112 otherUserAgentElement.value = userAgentSetting.get(); 112 otherUserAgentElement.value = userAgentSetting.get();
113 otherUserAgentElement.title = userAgentSetting.get(); 113 otherUserAgentElement.title = userAgentSetting.get();
114 114
115 settingChanged(); 115 settingChanged();
116 userAgentSelectElement.addEventListener("change", userAgentSelected, false); 116 userAgentSelectElement.addEventListener("change", userAgentSelected, false);
117 117
118 otherUserAgentElement.addEventListener("dblclick", textDoubleClicked, true);
119 otherUserAgentElement.addEventListener("blur", textChanged, false); 118 otherUserAgentElement.addEventListener("blur", textChanged, false);
120 otherUserAgentElement.addEventListener("keydown", textKeyDown, false); 119 otherUserAgentElement.addEventListener("keyup", textChanged, false);
121 120
122 function userAgentSelected() 121 function userAgentSelected()
123 { 122 {
124 var value = userAgentSelectElement.options[userAgentSelectElement.select edIndex].value; 123 var value = userAgentSelectElement.options[userAgentSelectElement.select edIndex].value;
125 if (value !== customOverride.value) { 124 if (value !== customOverride.value) {
126 userAgentSetting.set(value); 125 userAgentSetting.set(value);
127 otherUserAgentElement.value = value; 126 otherUserAgentElement.value = value;
128 otherUserAgentElement.title = value; 127 otherUserAgentElement.title = value;
129 otherUserAgentElement.readOnly = true;
130 } else { 128 } else {
131 otherUserAgentElement.readOnly = false;
132 otherUserAgentElement.value = "";
133 otherUserAgentElement.focus(); 129 otherUserAgentElement.focus();
134 } 130 }
135 } 131 }
136 132
137 function settingChanged() 133 function settingChanged()
138 { 134 {
139 var value = userAgentSetting.get(); 135 var value = userAgentSetting.get();
140 var options = userAgentSelectElement.options; 136 var options = userAgentSelectElement.options;
141 var selectionRestored = false; 137 var selectionRestored = false;
142 for (var i = 0; i < options.length; ++i) { 138 for (var i = 0; i < options.length; ++i) {
143 if (options[i].value === value) { 139 if (options[i].value === value) {
144 userAgentSelectElement.selectedIndex = i; 140 userAgentSelectElement.selectedIndex = i;
145 selectionRestored = true; 141 selectionRestored = true;
146 break; 142 break;
147 } 143 }
148 } 144 }
149 145
150 otherUserAgentElement.readOnly = selectionRestored;
151 if (!selectionRestored) 146 if (!selectionRestored)
152 userAgentSelectElement.selectedIndex = 0; 147 userAgentSelectElement.selectedIndex = 0;
153 148
154 if (otherUserAgentElement.value !== value) { 149 if (otherUserAgentElement.value !== value) {
155 otherUserAgentElement.value = value; 150 otherUserAgentElement.value = value;
156 otherUserAgentElement.title = value; 151 otherUserAgentElement.title = value;
157 } 152 }
158 } 153 }
159 154
160 function textKeyDown(event)
161 {
162 if (isEnterKey(event))
163 textChanged();
164 }
165
166 function textDoubleClicked()
167 {
168 if (userAgentSelectElement.selectedIndex === 0)
169 return;
170 userAgentSelectElement.selectedIndex = 0;
171 userAgentSelected();
172 }
173
174 function textChanged() 155 function textChanged()
175 { 156 {
176 if (userAgentSetting.get() !== otherUserAgentElement.value) { 157 if (userAgentSetting.get() !== otherUserAgentElement.value) {
177 userAgentSetting.set(otherUserAgentElement.value); 158 userAgentSetting.set(otherUserAgentElement.value);
178 settingChanged(); 159 settingChanged();
179 } 160 }
180 } 161 }
181 162
182 return { select: userAgentSelectElement, input: otherUserAgentElement }; 163 return { select: userAgentSelectElement, input: otherUserAgentElement };
183 } 164 }
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 * @param {!WebInspector.Context} context 269 * @param {!WebInspector.Context} context
289 * @param {string} actionId 270 * @param {string} actionId
290 * @return {boolean} 271 * @return {boolean}
291 */ 272 */
292 handleAction: function(context, actionId) 273 handleAction: function(context, actionId)
293 { 274 {
294 WebInspector.inspectorView.showViewInDrawer("network.config"); 275 WebInspector.inspectorView.showViewInDrawer("network.config");
295 return true; 276 return true;
296 } 277 }
297 } 278 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698