Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1918613002:
DevTools: Switching to custom user agent no longer clears preexisting value (Closed)
|
Created:
4 years, 8 months ago by luoe Modified:
4 years, 7 months ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org, paulirish Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Switching to custom user agent no longer clears preexisting value
BUG=604833
Committed: https://crrev.com/0ce96ed769ae4aa03ec68d23f92e9f1b3441c2ba
Cr-Commit-Position: refs/heads/master@{#390128}
Patch Set 1 #Patch Set 2 : Re-added readonly #
Total comments: 2
Patch Set 3 : Address comments in patch 2 #Patch Set 4 : Made input always editable #Messages
Total messages: 20 (8 generated)
luoe@chromium.org changed reviewers: + lushnikov@chromium.org
Lets have the user agents read-only. As user does double-click in the user agent field, let's switch to custom and make the field editable, preserving the previous value.
On 2016/04/25 23:51:23, lushnikov wrote: > Lets have the user agents read-only. > > As user does double-click in the user agent field, let's switch to custom and > make the field editable, preserving the previous value. Yeah, I could see how readonly eliminates confusion around editable presets. Done.
thanks, lgtm https://codereview.chromium.org/1918613002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js (left): https://codereview.chromium.org/1918613002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js:169: return; semicolon is actually needed after the "return"
Made input always editable. Now checks for a changed value on keyUp instead of keyDown. https://codereview.chromium.org/1918613002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js (left): https://codereview.chromium.org/1918613002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js:169: return; On 2016/04/26 16:39:17, lushnikov wrote: > semicolon is actually needed after the "return" Done.
The CQ bit was checked by luoe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/1918613002/#ps60001 (title: "Made input always editable")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918613002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918613002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918613002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0ce96ed769ae4aa03ec68d23f92e9f1b3441c2ba Cr-Commit-Position: refs/heads/master@{#390128}
Message was sent while issue was closed.
Description was changed from ========== DevTools: Switching to custom user agent no longer clears preexisting value BUG=604833 ========== to ========== DevTools: Switching to custom user agent no longer clears preexisting value BUG=604833 Committed: https://crrev.com/0ce96ed769ae4aa03ec68d23f92e9f1b3441c2ba Cr-Commit-Position: refs/heads/master@{#390128} ========== |
