Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 19186002: Introduce toHTMLLinkElement (Closed)

Created:
7 years, 5 months ago by kangil_
Modified:
7 years, 5 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, gavinp+prerender_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce toHTMLLinkElement To avoid direct use of static_cast, this patch introduces toHTMLLinkElement for code cleanup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/StyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kangil_
review please? :)
7 years, 5 months ago (2013-07-15 12:47:21 UTC) #1
tkent
lgtm
7 years, 5 months ago (2013-07-15 12:54:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19186002/1
7 years, 5 months ago (2013-07-15 12:54:48 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-15 13:25:47 UTC) #4
Message was sent while issue was closed.
Change committed as 154224

Powered by Google App Engine
This is Rietveld 408576698