Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1918593002: cc : Stop pushing properties not used by LayerImpl to LayerImpl (3) (Closed)

Created:
4 years, 8 months ago by jaydasika
Modified:
4 years, 8 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, kinuko+watch, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, cc-bugs_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Stop pushing properties not used by LayerImpl to LayerImpl (3) This CL removes pushing properties : is_root_for_isolated_group, is_container_for_fixed_pos_layer, position_constraint, should_flatten_transform, transform_is_invertible, num_descendants_that_draw_content BUG=602438 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64 Cr-Commit-Position: refs/heads/master@{#389349}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -231 lines) Patch
M cc/layers/layer.cc View 2 chunks +1 line, -7 lines 0 comments Download
M cc/layers/layer_impl.h View 7 chunks +0 lines, -40 lines 0 comments Download
M cc/layers/layer_impl.cc View 11 chunks +1 line, -52 lines 0 comments Download
M cc/layers/layer_impl_test_properties.h View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 7 chunks +0 lines, -47 lines 0 comments Download
M cc/layers/layer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/layer_tree_host_common_test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/layer_tree_host_common_test.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 2 chunks +7 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 12 chunks +26 lines, -26 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 12 chunks +20 lines, -13 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 13 chunks +55 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
jaydasika
PTAL
4 years, 8 months ago (2016-04-22 23:38:45 UTC) #5
ajuma
lgtm A heads-up that Wei has a CL (https://codereview.chromium.org/1906003002/) that deletes Layer::transform_is_invertible entirely (and removes ...
4 years, 8 months ago (2016-04-23 00:11:04 UTC) #7
jaydasika
https://codereview.chromium.org/1918593002/diff/1/cc/trees/property_tree_builder.cc File cc/trees/property_tree_builder.cc (right): https://codereview.chromium.org/1918593002/diff/1/cc/trees/property_tree_builder.cc#newcode533 cc/trees/property_tree_builder.cc:533: static inline bool NumDescendantsThatDrawContent(LayerImpl* layer) { Whoops! this should ...
4 years, 8 months ago (2016-04-23 00:16:16 UTC) #8
jaydasika
vollick : Can you review changes to platform/graphics ?
4 years, 8 months ago (2016-04-23 00:19:18 UTC) #9
Ian Vollick
On 2016/04/23 00:19:18, jaydasika wrote: > vollick : Can you review changes to platform/graphics ? ...
4 years, 8 months ago (2016-04-23 00:40:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918593002/40001
4 years, 8 months ago (2016-04-23 02:02:23 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-23 02:53:03 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 02:54:00 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64
Cr-Commit-Position: refs/heads/master@{#389349}

Powered by Google App Engine
This is Rietveld 408576698