Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1918583002: Add field trial testing config for MojoChannel (Closed)

Created:
4 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add field trial testing config for MojoChannel R=asvitkine@chromium.org BUG= Committed: https://crrev.com/bf36f2d46f43eff11f56ea205615f092801b1004 Cr-Commit-Position: refs/heads/master@{#389497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Ken Rockot(use gerrit already)
4 years, 8 months ago (2016-04-22 23:05:05 UTC) #1
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-04-25 15:34:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918583002/1
4 years, 8 months ago (2016-04-25 15:40:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 16:44:41 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bf36f2d46f43eff11f56ea205615f092801b1004 Cr-Commit-Position: refs/heads/master@{#389497}
4 years, 8 months ago (2016-04-25 16:47:14 UTC) #7
dmurph
On 2016/04/25 at 16:47:14, commit-bot wrote: > Patchset 1 (id:??) landed as https://crrev.com/bf36f2d46f43eff11f56ea205615f092801b1004 > Cr-Commit-Position: ...
4 years, 7 months ago (2016-05-09 19:03:01 UTC) #8
dmurph
On 2016/05/09 at 19:03:01, dmurph wrote: > On 2016/04/25 at 16:47:14, commit-bot wrote: > > ...
4 years, 7 months ago (2016-05-09 19:03:53 UTC) #9
Ken Rockot(use gerrit already)
On 2016/05/09 at 19:03:53, dmurph wrote: > On 2016/05/09 at 19:03:01, dmurph wrote: > > ...
4 years, 7 months ago (2016-05-09 19:07:05 UTC) #10
Alexei Svitkine (slow)
4 years, 7 months ago (2016-05-09 19:09:16 UTC) #11
Message was sent while issue was closed.
The configs enable the behavior to be tested by perf bots. So if there's a
regression, it means the experiment is causing it.

On Mon, May 9, 2016 at 3:07 PM, <rockot@chromium.org> wrote:

> On 2016/05/09 at 19:03:53, dmurph wrote:
> > On 2016/05/09 at 19:03:01, dmurph wrote:
> > > On 2016/04/25 at 16:47:14, commit-bot wrote:
> > > > Patchset 1 (id:??) landed as
> https://crrev.com/bf36f2d46f43eff11f56ea205615f092801b1004
> > > > Cr-Commit-Position: refs/heads/master@{#389497}
> > >
> > > Is there any reason why this would cause a perf regression? We see it
> here:
> > > https://bugs.chromium.org/p/chromium/issues/detail?id=609946
> >
> > https://bugs.chromium.org/p/chromium/issues/detail?id=606760
>
> Depends. It is entirely possible that the experiment itself would cause a
> perf
> regression, but
> this CL just adds testing configs for the experiment.
>
> I don't know how testing configs interact with perf bots.
>
> Also note that this experiment no longer exists on ToT.
>
> https://codereview.chromium.org/1918583002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698