content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java - Issue 1918523003: Fix Android set selection action (selection end was ignored)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 1918523003: Fix Android set selection action (selection end was ignored) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inline_text_boxes_of_focus

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

index bc5188348ae06b1f433fc541b97a00ad555bba49..cfb62cca6bfda9a5cfd450f78b121ef38b1983ca 100644

--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

@@ -270,7 +270,7 @@ public class BrowserAccessibilityManager {

selectionStart = arguments.getInt(

AccessibilityNodeInfo.ACTION_ARGUMENT_SELECTION_START_INT);

selectionEnd = arguments.getInt(

- AccessibilityNodeInfo.ACTION_ARGUMENT_SELECTION_START_INT);

+ AccessibilityNodeInfo.ACTION_ARGUMENT_SELECTION_END_INT);

}

nativeSetSelection(mNativeObj, virtualViewId, selectionStart, selectionEnd);

return true;

« no previous file with comments | « no previous file | no next file » | no next file with comments »