Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1918503002: PPC64: [simulator] Do not sign-extend uint32_t call parameters. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, JaideepBajwa, JoranSiu
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC64: [simulator] Do not sign-extend uint32_t call parameters. R=bmeurer@chromium.org, titzer@chromium.org, mstarzinger@chromium.org BUG= Committed: https://crrev.com/3bb5b67204db3a86909f8a4a86a8ea4afcb544e7 Cr-Commit-Position: refs/heads/master@{#35766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/cctest/compiler/call-tester.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
MTBrandyberry
PTAL. This fixes the current set of PPC64 failures.
4 years, 8 months ago (2016-04-22 20:35:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918503002/1
4 years, 8 months ago (2016-04-22 20:35:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 20:57:45 UTC) #8
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-23 11:59:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918503002/1
4 years, 8 months ago (2016-04-25 13:38:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 14:03:47 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 14:04:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bb5b67204db3a86909f8a4a86a8ea4afcb544e7
Cr-Commit-Position: refs/heads/master@{#35766}

Powered by Google App Engine
This is Rietveld 408576698