Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issue 19185006: Support decoding Gray to A8 in PNG. (Closed)

Created:
7 years, 5 months ago by scroggo
Modified:
7 years, 5 months ago
Reviewers:
Chris Craik, djsollen, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Support decoding Gray to A8 in PNG. Move the code which sets the filler and forces gray to rgb after we get the config, so we can skip them if the caller wants A8. Call set_gray_to_rgb consistently for both normal decode and subset decode. In PNG, prevent subset decodes from alternating configs, which would otherwise fail. Use SK_RESTRICT for pointers in getBitmapConfig. Ref the SkStream input to buildTileIndex, so it will not be destroyed before calling decodeSubset. Convert some fields to match Skia style. Builds on https://codereview.chromium.org/18083026/, which has not yet been checked in. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=10162

Patch Set 1 #

Patch Set 2 : Fix bugs. #

Patch Set 3 : Remove an accidental insertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -30 lines) Patch
M src/images/SkImageDecoder_libpng.cpp View 1 2 14 chunks +78 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
7 years, 5 months ago (2013-07-15 21:13:24 UTC) #1
scroggo
Oops, removing Mike's personal email. This change still has a bug, as it allows tile ...
7 years, 5 months ago (2013-07-16 16:09:05 UTC) #2
scroggo
Latest patch fixes the aforementioned bug.
7 years, 5 months ago (2013-07-16 21:09:12 UTC) #3
reed1
lgtm
7 years, 5 months ago (2013-07-18 14:21:04 UTC) #4
scroggo
7 years, 5 months ago (2013-07-18 20:03:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r10162 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698