Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1918473002: Document WebGL2 CTS expectations findings (Closed)

Created:
4 years, 8 months ago by cwallez
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Document WebGL2 CTS expectations findings Investigation on the WebGL2 CTS errors with the ANGLE OpenGL backend unveiled some of the root causes behind current WebGL2 test expectations, document those. BUG=605775 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e7c0dedac68558ab07a0b2e57b8cdb6242e698dd Cr-Commit-Position: refs/heads/master@{#389222}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 2 chunks +4 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
Corentin Wallez
PTAL, just adds a couple comments
4 years, 8 months ago (2016-04-22 18:46:46 UTC) #4
Ken Russell (switch to Gerrit)
Excellent. LGTM
4 years, 8 months ago (2016-04-22 18:49:59 UTC) #5
Zhenyao Mo
This is great! https://codereview.chromium.org/1918473002/diff/1/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/1918473002/diff/1/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py#newcode99 content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:99: # CopyTexImage2D so that for example ...
4 years, 8 months ago (2016-04-22 18:50:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918473002/1
4 years, 8 months ago (2016-04-22 18:50:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 20:18:15 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 20:19:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7c0dedac68558ab07a0b2e57b8cdb6242e698dd
Cr-Commit-Position: refs/heads/master@{#389222}

Powered by Google App Engine
This is Rietveld 408576698