Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: content/browser/media/session/media_session_uma_helper.cc

Issue 1918433003: Use TimeTicks for MediaSessionUmaHelper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/media/session/media_session_uma_helper.h" 5 #include "content/browser/media/session/media_session_uma_helper.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/metrics/histogram_base.h" 9 #include "base/metrics/histogram_base.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
11 #include "base/time/default_clock.h" 11 #include "base/time/default_tick_clock.h"
12 12
13 namespace content { 13 namespace content {
14 14
15 using HistogramBase = base::HistogramBase; 15 using HistogramBase = base::HistogramBase;
16 16
17 MediaSessionUmaHelper::MediaSessionUmaHelper() 17 MediaSessionUmaHelper::MediaSessionUmaHelper()
18 : clock_(new base::DefaultClock()) 18 : clock_(new base::DefaultTickClock())
19 {} 19 {}
20 20
21 MediaSessionUmaHelper::~MediaSessionUmaHelper() 21 MediaSessionUmaHelper::~MediaSessionUmaHelper()
22 {} 22 {}
23 23
24 void MediaSessionUmaHelper::RecordSessionSuspended( 24 void MediaSessionUmaHelper::RecordSessionSuspended(
25 MediaSessionSuspendedSource source) const { 25 MediaSessionSuspendedSource source) const {
26 UMA_HISTOGRAM_ENUMERATION( 26 UMA_HISTOGRAM_ENUMERATION(
27 "Media.Session.Suspended", 27 "Media.Session.Suspended",
28 static_cast<HistogramBase::Sample>(source), 28 static_cast<HistogramBase::Sample>(source),
29 static_cast<HistogramBase::Sample>(MediaSessionSuspendedSource::Count)); 29 static_cast<HistogramBase::Sample>(MediaSessionSuspendedSource::Count));
30 } 30 }
31 31
32 void MediaSessionUmaHelper::RecordRequestAudioFocusResult(bool result) const { 32 void MediaSessionUmaHelper::RecordRequestAudioFocusResult(bool result) const {
33 UMA_HISTOGRAM_BOOLEAN("Media.Session.RequestAudioFocusResult", result); 33 UMA_HISTOGRAM_BOOLEAN("Media.Session.RequestAudioFocusResult", result);
34 } 34 }
35 35
36 void MediaSessionUmaHelper::OnSessionActive() { 36 void MediaSessionUmaHelper::OnSessionActive() {
37 current_active_time_ = clock_->Now(); 37 current_active_time_ = clock_->NowTicks();
38 } 38 }
39 39
40 void MediaSessionUmaHelper::OnSessionSuspended() { 40 void MediaSessionUmaHelper::OnSessionSuspended() {
41 if (current_active_time_.is_null()) 41 if (current_active_time_.is_null())
42 return; 42 return;
43 43
44 total_active_time_ += clock_->Now() - current_active_time_; 44 total_active_time_ += clock_->NowTicks() - current_active_time_;
45 current_active_time_ = base::Time(); 45 current_active_time_ = base::TimeTicks();
46 } 46 }
47 47
48 void MediaSessionUmaHelper::OnSessionInactive() { 48 void MediaSessionUmaHelper::OnSessionInactive() {
49 if (!current_active_time_.is_null()) { 49 if (!current_active_time_.is_null()) {
50 total_active_time_ += clock_->Now() - current_active_time_; 50 total_active_time_ += clock_->NowTicks() - current_active_time_;
51 current_active_time_ = base::Time(); 51 current_active_time_ = base::TimeTicks();
52 } 52 }
53 53
54 if (total_active_time_.is_zero()) 54 if (total_active_time_.is_zero())
55 return; 55 return;
56 56
57 UMA_HISTOGRAM_LONG_TIMES("Media.Session.ActiveTime", total_active_time_); 57 UMA_HISTOGRAM_LONG_TIMES("Media.Session.ActiveTime", total_active_time_);
58 total_active_time_ = base::TimeDelta(); 58 total_active_time_ = base::TimeDelta();
59 } 59 }
60 60
61 void MediaSessionUmaHelper::SetClockForTest( 61 void MediaSessionUmaHelper::SetClockForTest(
62 std::unique_ptr<base::Clock> testing_clock) { 62 std::unique_ptr<base::TickClock> testing_clock) {
63 clock_ = std::move(testing_clock); 63 clock_ = std::move(testing_clock);
64 } 64 }
65 65
66 } // namespace content 66 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698