Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1918433002: Optionally enable SkValidatingReadBuffer in SkPictureImageFilter (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
msarett, reed1
CC:
reviews_skia.org, kjlubick
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Optionally enable SkValidatingReadBuffer in SkPictureImageFilter The task here is to get the type of ReadBuffer being used in SkPicture::MakeFromBuffer mirrored in the down-stack SkPicturePlayback::draw call. BUG=skia:5208 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918433002 Committed: https://skia.googlesource.com/skia/+/99e20891a080f39113bd7a5dc202730f2a13fa07

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : More clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M include/core/SkPicture.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkPicture.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M src/core/SkPicturePlayback.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +15 lines, -6 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkValidatingReadBuffer.h View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
robertphillips
4 years, 8 months ago (2016-04-22 17:32:57 UTC) #6
reed1
+matt api lgtm
4 years, 8 months ago (2016-04-22 17:56:37 UTC) #8
msarett
lgtm
4 years, 8 months ago (2016-04-22 18:17:36 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918433002/40001
4 years, 8 months ago (2016-04-22 18:19:33 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 18:28:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918433002/40001
4 years, 8 months ago (2016-04-22 18:39:47 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 18:40:45 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/99e20891a080f39113bd7a5dc202730f2a13fa07

Powered by Google App Engine
This is Rietveld 408576698