Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1918423002: Fix TaskmanagerIoThreadHelper bug. (Closed)

Created:
4 years, 8 months ago by ncarter (slow)
Modified:
4 years, 8 months ago
Reviewers:
afakhry
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TaskmanagerIoThreadHelper bug. Deleting the TaskManagerIoThreadHelper should cancel any pending OnMultipleBytesReadIO calls. If it doesn't, we can sometimes fail the DCHECK(!bytes_read_buffer_.empty()); check. BUG=None TEST=TaskManagerOOPIFBrowserTest.LeavePageWithCrossSiteIframes/0 Committed: https://crrev.com/39b8a004d4f83d3559628b51613891d2f4773304 Cr-Commit-Position: refs/heads/master@{#389889}

Patch Set 1 #

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918423002/1
4 years, 8 months ago (2016-04-26 19:49:26 UTC) #2
ncarter (slow)
This was uncovered by the old TaskManagerBrowserTests. Please review.
4 years, 8 months ago (2016-04-26 19:51:18 UTC) #4
afakhry
On 2016/04/26 19:51:18, ncarter wrote: > This was uncovered by the old TaskManagerBrowserTests. Please review. ...
4 years, 8 months ago (2016-04-26 20:20:29 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 21:00:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918423002/1
4 years, 8 months ago (2016-04-26 21:11:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 21:17:21 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 21:18:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39b8a004d4f83d3559628b51613891d2f4773304
Cr-Commit-Position: refs/heads/master@{#389889}

Powered by Google App Engine
This is Rietveld 408576698