Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1918403003: Fix comment about when we rehash ObjectHashTables before growing them (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix comment about when we rehash ObjectHashTables before growing them R=ulan@chromium.org BUG= Committed: https://crrev.com/686558dcffa7433688bbe64eccb3c043935debe6 Cr-Commit-Position: refs/heads/master@{#35853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-04-27 10:43:28 UTC) #1
ulan
lgtm
4 years, 7 months ago (2016-04-27 12:49:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918403003/1
4 years, 7 months ago (2016-04-28 10:32:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 10:36:50 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:04 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/686558dcffa7433688bbe64eccb3c043935debe6
Cr-Commit-Position: refs/heads/master@{#35853}

Powered by Google App Engine
This is Rietveld 408576698