Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1918403002: [Reland] [Media Router Tests] Add tests for MediaRouterFactory. (Closed)

Created:
4 years, 8 months ago by imcheng
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, media-router+watch_chromium.org, mcasas+watch+vc_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] [Media Router Tests] Add tests for MediaRouterFactory. Changed to use std::unique_ptr in tests since scoped_ptr is being removed. Original patch: https://codereview.chromium.org/1877273002/ Revert: https://codereview.chromium.org/1916973003/ TBR=mfoltz@chromium.org Committed: https://crrev.com/71361c3f0ff47e543bb5db0233e64ef380df2eab Cr-Commit-Position: refs/heads/master@{#389892}

Patch Set 1 : Original patch #

Patch Set 2 : use unique_tpr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M chrome/browser/media/router/media_router_factory.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router_factory.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/browser/media/router/media_router_factory_unittest.cc View 1 1 chunk +68 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918403002/20001
4 years, 8 months ago (2016-04-26 21:21:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 21:26:38 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 21:27:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/71361c3f0ff47e543bb5db0233e64ef380df2eab
Cr-Commit-Position: refs/heads/master@{#389892}

Powered by Google App Engine
This is Rietveld 408576698