Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 19184002: Make deopt testing compatible with runtime optimization status queries. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach
Modified:
7 years, 5 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Make deopt testing compatible with runtime optimization status queries. When deopt testing is activated, a new status code will be returned by optimization status queries (status=maybe deopted). This will make those tests work that test for 'not status=no', when performing deopt testing. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15681

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/runtime.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
7 years, 5 months ago (2013-07-15 12:38:21 UTC) #1
Michael Achenbach
PTAL
7 years, 5 months ago (2013-07-15 13:59:24 UTC) #2
Jakob Kummerow
LGTM with comments. https://codereview.chromium.org/19184002/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/19184002/diff/1/src/runtime.cc#newcode8467 src/runtime.cc:8467: // The least significant bit (after ...
7 years, 5 months ago (2013-07-15 14:26:27 UTC) #3
Michael Achenbach
7 years, 5 months ago (2013-07-15 18:47:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698