chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h - Issue 1918373002: Metrics for document.write script blocking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

Issue 1918373002: Metrics for document.write script blocking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bryan's comment: Returning disallowFetch from shouldDisallowFetchForMainFrameScript Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

index a24421b2e7a2fed61f9494562618d791f1c18bf3..e39f9990530be40c1235c15212f4f20868e4ceba 100644

--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

@@ -10,8 +10,10 @@

namespace internal {

-// Just expose one metric for tests.

+// Expose metrics for tests.

extern const char kHistogramDocWriteParseStartToFirstContentfulPaint[];

+extern const char kHistogramDocWriteBlockParseStartToFirstContentfulPaint[];

+extern const char kHistogramDocWriteBlockReloadCount[];

} // namespace internal

@@ -29,6 +31,10 @@ class DocumentWritePageLoadMetricsObserver

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info);

+ void LogDocumentWriteBlockData(

+ const page_load_metrics::PageLoadTiming& timing,

+ const page_load_metrics::PageLoadExtraInfo& info);

DISALLOW_COPY_AND_ASSIGN(DocumentWritePageLoadMetricsObserver);

};