Metrics for document.write script blocking

components/page_load_metrics/browser/page_load_metrics_util.h

Index: components/page_load_metrics/browser/page_load_metrics_util.h
diff --git a/components/page_load_metrics/browser/page_load_metrics_util.h b/components/page_load_metrics/browser/page_load_metrics_util.h
index 380c077d26357ae6db44339bbbdacfe9b45692b6..26c6c92f2880223734d00333af342e8e0c100e39 100644
--- a/components/page_load_metrics/browser/page_load_metrics_util.h
+++ b/components/page_load_metrics/browser/page_load_metrics_util.h
@@ -25,9 +25,17 @@ struct PageLoadTiming;
 // When a page is backgrounded, some events (e.g. paint) are delayed. Since
 // these data points can skew the mean, they should not be mixed with timing
 // events that occurred in the foreground.
-bool WasStartedInForegroundEventInForeground(base::TimeDelta event,
+bool WasStartedInForegroundEventInForeground(const base::TimeDelta& event,

[Charlie Harrison, 2016/05/02 21:48:28]

Don't pass time values by const reference, pass by value. If you edit any
function that passes by const ref, convert it.

This is because the time values are intentionally made to only store 64 bit
integers.

[shivanisha, 2016/05/03 18:42:03]

Agree that will be consistent with most usages of TimeDelta in the code.
Changed.

                                              const PageLoadExtraInfo& info);
 
+// Returns true if:
+// - Parse started and did not complete but the entire page load duration
+// happened in the foreground.
+// - Parse completed and happened entirely in the foreground.
+bool WasParseInForeground(const base::TimeDelta& parse_start,
+                          const base::TimeDelta& parse_stop,
+                          const PageLoadExtraInfo& info);
+
 }  // namespace page_load_metrics
 
 #endif  // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_