Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: components/page_load_metrics/browser/page_load_metrics_util.cc

Issue 1918373002: Metrics for document.write script blocking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tests added and flags corrected. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/browser/page_load_metrics_util.h" 5 #include "components/page_load_metrics/browser/page_load_metrics_util.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h" 9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
10 #include "components/page_load_metrics/common/page_load_timing.h" 10 #include "components/page_load_metrics/common/page_load_timing.h"
11 11
12 namespace page_load_metrics { 12 namespace page_load_metrics {
13 13
14 bool WasStartedInForegroundEventInForeground(base::TimeDelta event, 14 bool WasStartedInForegroundEventInForeground(const base::TimeDelta& event,
15 const PageLoadExtraInfo& info) { 15 const PageLoadExtraInfo& info) {
16 return info.started_in_foreground && !event.is_zero() && 16 return info.started_in_foreground && !event.is_zero() &&
17 (info.first_background_time.is_zero() || 17 (info.first_background_time.is_zero() ||
18 event < info.first_background_time); 18 event < info.first_background_time);
19 } 19 }
20 20
21 bool WasParseInForeground(const base::TimeDelta& parse_start,
Charlie Harrison 2016/05/02 21:48:28 ditto here.
shivanisha 2016/05/03 18:42:03 done.
22 const base::TimeDelta& parse_stop,
23 const PageLoadExtraInfo& info) {
24 if (parse_start.is_zero()) {
25 return false;
26 }
27 const bool incomplete_parse_in_foreground =
28 parse_stop.is_zero() && info.started_in_foreground &&
29 info.first_background_time.is_zero();
30
31 return incomplete_parse_in_foreground ||
32 WasStartedInForegroundEventInForeground(parse_stop, info);
33 }
21 } // namespace page_load_metrics 34 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698