Chromium Code Reviews Chromium Code Reviews
Issue 1918373002:
Metrics for document.write script blocking (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 34e02a3ff0a02d44f7eb9fdce70700eb3fbfc5fb..f3d07effff244ea0b1deade0b2dab55308e4e4be 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -34599,6 +34599,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="PageLoad.Clients.DocWrite.Block.Reloads"> |
|
Bryan McQuade
2016/04/26 19:35:44
maybe ReloadCount rather than Reloads to be explic
shivanisha
2016/04/27 13:34:34
done.
|
| + <owner>shivanisha@chromium.org</owner> |
| + <owner>bmcquade@chromium.org</owner> |
| + <summary> |
| + Reloads in pages that have blockable document.written scripts. |
|
jkarlin
2016/04/26 20:16:21
When is a script blockable?
shivanisha
2016/04/27 13:34:34
Updated to mention cross-origin and synchronous.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="PageLoad.Clients.GoogleCaptcha.Events" |
| enum="GoogleCaptchaEvent"> |
| <owner>mdw@chromium.org</owner> |
| @@ -91712,6 +91720,16 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <histogram_suffixes name="PageLoadBackgrounded2" separator="."> |
| <affected-histogram |
| + name="PageLoad.Clients.DocWrite.Block.Timing2.ParseBlockedOnScriptLoad"/> |
| + <affected-histogram |
| + name="PageLoad.Clients.DocWrite.Block.Timing2.ParseBlockedOnScriptLoad.ParseComplete"/> |
| + <affected-histogram |
| + name="PageLoad.Clients.DocWrite.Block.Timing2.ParseBlockedOnScriptLoadFromDocumentWrite"/> |
| + <affected-histogram |
| + name="PageLoad.Clients.DocWrite.Block.Timing2.ParseBlockedOnScriptLoadFromDocumentWrite.ParseComplete"/> |
| + <affected-histogram |
| + name="PageLoad.Clients.DocWrite.Block.Timing2.ParseDuration"/> |
| + <affected-histogram |
| name="PageLoad.Clients.DocWrite.Evaluator.Timing2.NavigationToFirstContentfulPaint"/> |
| <affected-histogram |
| name="PageLoad.Clients.DocWrite.Evaluator.Timing2.ParseBlockedOnScriptLoad"/> |
| @@ -91772,6 +91790,10 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <suffix name="Clients.DocWrite.Evaluator" |
| label="PageLoadMetrics from a page that could have been evaluated by |
| the DocumentWriteEvaluator"/> |
| + <suffix name="Clients.DocWrite.Block" |
| + label="PageLoadMetrics from a page that have synchronous |
| + document.written cross-origin scripts that could be blocked if |
| + the feature is enabled."/> |
|
jkarlin
2016/04/26 20:16:21
If what feature is enabled?
shivanisha
2016/04/27 13:34:34
Updated to mention "document.write script blocking
|
| <affected-histogram |
| name="PageLoad.Timing2.DOMLoadingToDOMContentLoadedEventFired"/> |
| <affected-histogram name="PageLoad.Timing2.DOMLoadingToFirstContentfulPaint"/> |
