Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "components/page_load_metrics/browser/page_load_metrics_util.h" | 5 #include "components/page_load_metrics/browser/page_load_metrics_util.h" |
| 6 | 6 |
| 7 #include <algorithm> | 7 #include <algorithm> |
| 8 | 8 |
| 9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h" | 9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h" |
| 10 #include "components/page_load_metrics/common/page_load_timing.h" | 10 #include "components/page_load_metrics/common/page_load_timing.h" |
| 11 | 11 |
| 12 namespace page_load_metrics { | 12 namespace page_load_metrics { |
| 13 | 13 |
| 14 bool WasStartedInForegroundEventInForeground(base::TimeDelta event, | 14 bool WasStartedInForegroundEventInForeground(const base::TimeDelta& event, |
| 15 const PageLoadExtraInfo& info) { | 15 const PageLoadExtraInfo& info) { |
| 16 return info.started_in_foreground && !event.is_zero() && | 16 return info.started_in_foreground && !event.is_zero() && |
| 17 (info.first_background_time.is_zero() || | 17 (info.first_background_time.is_zero() || |
| 18 event < info.first_background_time); | 18 event < info.first_background_time); |
| 19 } | 19 } |
| 20 | 20 |
| 21 bool ParseInForeground(const base::TimeDelta& parse_start, | |
| 22 const base::TimeDelta& parse_stop, | |
| 23 const PageLoadExtraInfo& info) { | |
| 24 if (parse_start.is_zero()) { | |
| 25 return false; | |
| 26 } | |
| 27 // If the parse did not complete but the entire page load duration happened | |
| 28 // in the foreground, or if the parse completed and happened entirely in the | |
| 29 // foreground, record a foreground histogram. | |
| 30 const bool incomplete_parse_in_foreground = | |
| 31 parse_stop.is_zero() && info.started_in_foreground && | |
| 32 info.first_background_time.is_zero(); | |
| 33 | |
| 34 return (incomplete_parse_in_foreground || | |
| 35 WasStartedInForegroundEventInForeground(parse_stop, info)); | |
|
jkarlin
2016/04/26 20:16:21
No need for extra parens
shivanisha
2016/04/27 13:34:33
removed extra parens.
| |
| 36 } | |
| 21 } // namespace page_load_metrics | 37 } // namespace page_load_metrics |
| OLD | NEW |